Skip to content

Fix BOLA: PUT /users/v1/{username}/password can no longer change another user's password #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beanbeah wants to merge 1 commit into from
Closed

Fix BOLA: PUT /users/v1/{username}/password can no longer change another user's password #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api_views/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ def update_password(username):
else:
if request_data.get('password'):
if vuln: # Unauthorized update of password of another user
if username != resp.get('sub'):
return Response(error_message_helper("You are not authorized to change the password of another user"),
403, mimetype="application/json")
user = User.query.filter_by(username=username).first()
if user:
user.password = request_data.get('password')
Expand Down
Loading