Skip to content

fix: SQL Injection 7 - parameterize userEmail in login query #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beanbeah wants to merge 2 commits into from
Closed

fix: SQL Injection 7 - parameterize userEmail in login query #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bacedfa
fix: parameterize userEmail in SqlInjection7 login query
beanbeah Aug 9, 2026
3887b13
Add strict email-shape check to close SqlInjection7's format-validato…
beanbeah Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/java/servlets/module/challenge/SqlInjection7.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,24 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
log.debug("subEmail - " + subEmail.replaceAll("\n", " \\\\n ")); // Escape \n's
String subPassword = Validate.validateParameter(request.getParameter("subPassword"), 40);
log.debug("subPassword - " + subPassword);
// javax.mail's InternetAddress (used below) happily accepts an RFC822 quoted-string
// local part, which may contain almost any character - including an unescaped single
// quote - so relying on it alone as an input filter is not enough. A sign-in email has
// no legitimate reason to need quoting, so require a plain unquoted address shape first.
boolean looksLikePlainEmail =
subEmail.matches("[A-Za-z0-9!#$%&'*+/=?^_`{|}~.-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,}");
boolean validEmail =
Validate.isValidEmailAddress(subEmail.replaceAll("\n", "")); // Ignore \n 's
looksLikePlainEmail
&& Validate.isValidEmailAddress(subEmail.replaceAll("\n", "")); // Ignore \n 's
if (!subPassword.isEmpty() && !subPassword.isEmpty() && validEmail) {
Connection conn = Database.getChallengeConnection(applicationRoot, "SqlChallengeSeven");
try {
log.debug("Signing in with subitted details");
PreparedStatement prepstmt =
conn.prepareStatement(
"SELECT userName FROM users WHERE userEmail = '"
+ subEmail
+ "' AND userPassword = ?;");
prepstmt.setString(1, subPassword);
"SELECT userName FROM users WHERE userEmail = ? AND userPassword = ?;");
prepstmt.setString(1, subEmail);
prepstmt.setString(2, subPassword);
ResultSet users = prepstmt.executeQuery();
if (users.next()) {
htmlOutput =
Expand Down
Loading