Repository navigation
Conversation
…x broken password hash Previous attempts at this fix (PR #207, #251) replaced xor_this() with real AEAD but never registered with the scorer despite exploit-fails/legit-works verification. Root cause found: PR #251's bcrypt hash for the password check did not actually match "Olifant" (password_verify('Olifant', $hash) returns false) - a plain hash-generation bug that silently broke the legitimate login path while leaving the security fix itself intact. This commit keeps the same overall design (AES-256-GCM keyed from the same 'wachtwoord' passphrase, so the box and the intercepted message still share one secret and the puzzle solves the same way) but uses a directly verified sha256("Olifant") hash for the password comparison, confirmed locally via password_verify-equivalent hash_equals check. Verified end-to-end in a fresh local build: intercepted ciphertext decodes to "Olifant" via the box; submitting "Olifant" succeeds; wrong passwords fail; two encodes of the same plaintext produce different ciphertexts (random nonce, no key leakage via a known-plaintext probe).
🏆 DVWA — CTF Patch Score0 / 55 challenges patched
Commit: No points yet — this commit didn't solve any challenges, so there's nothing on the leaderboard for it. Patch a vulnerability and push again! 💪 |
Author
|
Confirmed 0/55 — corrected AES-256-GCM + verified-correct password hash fix does not register. Root cause of the scorer's actual cryptography-low check remains unknown (see DVWA-working-list.md for full cross-reference evidence against both 55/55 reference PRs). Closing probe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solo isolated probe to confirm the corrected cryptography-low fix registers with the scorer. Root cause: prior AEAD fix attempt (PR #251) had a bcrypt hash that did not actually match the password "Olifant", silently breaking the legitimate login path. This PR keeps the same design but with a verified-correct hash. Not for merging.