r.to.rast3elev: Check return-value for 'scanf'-like functions#7660
Open
echoix wants to merge 1 commit into
Open
r.to.rast3elev: Check return-value for 'scanf'-like functions#7660echoix wants to merge 1 commit into
echoix wants to merge 1 commit into
Conversation
… check for a 'scanf'-like function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
github-actions
Bot
added
raster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From me:
Resolves two CodeQL warning.
In https://en.cppreference.com/c/io/fscanf, it shows how the return value of sscanf is the number of successfully assigned arguments, with can also be zero or EOF.
The change is to explicitly check for the value 1.
From the auto fix (adapted):
Potential fix for https://github.com/OSGeo/grass/security/code-scanning/529
And https://github.com/OSGeo/grass/security/code-scanning/530
The correct fix is to validate
sscanfreturn values against the exact expected number of matched items, not just truthiness.In
raster/r.to.rast3elev/main.c, update both numeric parsing checks:if (sscanf(param.upper->answer, "%lf", &db.upper))if (sscanf(param.lower->answer, "%lf", &db.lower))Change each condition to
== 1, since each call expects exactly one%lfconversion. This preserves existing behavior for valid input while correctly rejecting parse failures and any non-success return values (includingEOF).No new methods, imports, or dependencies are needed.