t.list: add regression test for listing from a mapset without a temporal database#7640
t.list: add regression test for listing from a mapset without a temporal database#7640Valyrian-Code wants to merge 7 commits into
Conversation
ninsbl
left a comment
There was a problem hiding this comment.
Thanks. This indeed fixes the related bug.
So, I am inclined to approve the PR.
However, the suggested change would also bring us back to the behavior before #7576, in that sense that in a mapset without a TGIS database, the latter would be created by t.list. So when we merge this we may have to reopen #7576.
That said, #7631 adds some changes to t.list, that bring us one step closed to not depend on a TGIS database in the current mapset. So, I would go for merging this, reopen #7576 and probably address the TGIS DB requirement in the current mapset in a more general issue...
What do you think @petrasovaa ?
|
Thanks @ninsbl, that plan sounds right to me: merge this to fix #7622, reopen #7576, and track the "don't require a TGIS database in the current mapset" goal as a separate, more general issue (building on the direction in #7631). Just to keep the scope clear: this PR preserves the #7580 behavior for the truly-empty case (no temporal database in any accessible mapset still short-circuits with the friendly message and creates nothing). The case you're flagging is where a database exists in another accessible mapset but not the current one, where t.list now proceeds, and that's where the pre-#7576 current-mapset creation comes back. Happy to reopen #7576 and open the general issue once you and @petrasovaa are aligned on the direction. |
Yes, exactly. |
|
Thanks again, @Valyrian-Code . #7631 solves both issues If you like, modify the PR to add only the regression test. Otherwise, I would rather go for closing this. |
Per review, this now adds only the regression test for #7622: it lists datasets from a temporary mapset while the dataset lives in PERMANENT, so the case of running t.list from a mapset without a temporal database stays covered.
The behavior fix itself lands in #7631. I checked out that branch locally and this test passes with it, and fails on current main, so CI here will stay red until #7631 is merged. Happy to update the branch after that.