Repository navigation
Conversation
Collaborator
|
I think this needs more discussion. I am setting this to draft until we decide how to proceed. Having said that, this PR is very helpful and a good suggestion. More discussion in #482 is needed. |
lukelowry
force-pushed
the
lukel/model-schema-dev
branch
from
October 13, 2026 22:04
807fc28 to
3b32152
Compare
Collaborator
|
based on my current read of this, i think that it duplicates too much from |
lukelowry
force-pushed
the
lukel/model-schema-dev
branch
2 times, most recently
from
October 21, 2026 04:31
960d257 to
d6ec743
Compare
Collaborator
Author
|
@superwhiskers @pelesh Give this another look, it is much better. This moves us toward simpler input format parser, SystemModel composition, and feasibly be used to construct a JSON schema, aswell. |
lukelowry
force-pushed
the
lukel/model-schema-dev
branch
from
October 22, 2026 16:59
d6ec743 to
58ddf45
Compare
lukelowry
force-pushed
the
lukel/model-schema-dev
branch
from
October 22, 2026 17:52
58ddf45 to
374d12e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
MANIFESTto component data: the units, symbol and description of every parameter, port and monitor, declared in each model's*Data.hppbeside the enums it describes.ComponentLibrarylists the models that have one, so applications can query GridKit models without a priori information.Closes #482.
@pelesh @superwhiskers
Proposed changes
ComponentManifestholds the units, symbol and description of a component's parameters, buses, inputs, outputs and monitors.MANIFESTin their*Data.hpp. The build fails if any enum value is left undescribed.ComponentLibrarylists the models that have a manifest.ComponentManifestTests.For example, the IEEET1 inputs:
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
SystemModelare unchanged.ComponentLibrarylists model types so the system composer can construct through it later.