Skip to content

OPUSVIER-4493: Unterstützung des secure Cookie-Flag #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschaszott wants to merge 2 commits into
base: v4.9
Choose a base branch
from
Open

OPUSVIER-4493: Unterstützung des secure Cookie-Flag #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02c82c
OPUSVIER-4493: add session.cookie_secure option (disabled by default)
saschaszott Dec 10, 2020
f06d3c1
OPUSVIER-4493: allow to enable cookie flag secure in installation pro…
saschaszott Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apacheconf/apache22.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Alias /OPUS_URL_BASE "/BASEDIR/public"
# Setting cookie options
php_value session.cookie_path /OPUS_URL_BASE
php_value session.cookie_httponly on
php_value session.cookie_secure off

# On Debian/Ubuntu, prevent PHP from deleting the cookies
#Enable for UBUNTU/DEBIAN:# php_value session.gc_probability 0
Expand Down
1 change: 1 addition & 0 deletions apacheconf/apache24.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Alias /OPUS_URL_BASE "/BASEDIR/public"
# Setting cookie options
php_value session.cookie_path /OPUS_URL_BASE
php_value session.cookie_httponly on
php_value session.cookie_secure off

# On Debian/Ubuntu, prevent PHP from deleting the cookies
#Enable for UBUNTU/DEBIAN:# php_value session.gc_probability 0
Expand Down
6 changes: 6 additions & 0 deletions bin/install-apache.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ then
sed -i -e 's!#Enable for UBUNTU/DEBIAN:# !!' "$OUTPUT_FILE"
fi

read -p 'Enable cookie flag "secure" (only applicable if OPUS installation uses HTTPS) [N]: ' ENABLE_SECURE_FLAG
if [ "$ENABLE_SECURE_FLAG" = Y ] || [ "$ENABLE_SECURE_FLAG" = y ] ;
then
sed -i -e 's!php_value session.cookie_secure off!php_value session.cookie_secure on!' "$OUTPUT_FILE"
fi

[ -z "$APACHE_ADD_SITE" ] && read -p "Add site to Apache2 [Y]: " APACHE_ADD_SITE

if [ -z "$APACHE_ADD_SITE" ] || [ "$APACHE_ADD_SITE" = Y ] || [ "$APACHE_ADD_SITE" = y ] ;
Expand Down