Unit test experiment - these were written by codex#335
Merged
jgallagher59701 merged 5 commits intomasterfrom Feb 24, 2026
Merged
Unit test experiment - these were written by codex#335jgallagher59701 merged 5 commits intomasterfrom
jgallagher59701 merged 5 commits intomasterfrom
Conversation
|
hannahilea
reviewed
Feb 24, 2026
hannahilea
approved these changes
Feb 24, 2026
| return v; | ||
| } | ||
|
|
||
| return TRUE; |
Member
Author
There was a problem hiding this comment.
Yeah... That was an actual bug that the new tests caught.
Co-authored-by: Hannah Robertson <hannahilea@users.noreply.github.com>
Member
Author
|
Good catch on the .gitignore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch: jhrg/more-unit-tests
An experiment at expanding unit test coverage using Codex - a ChatGPT model. I used it to analyze the entire libdap4 repo and choose new code to test based where tests would do the most good. One test, for DAPCache3 was bogus, since that class is not used, but one test found a bug in the check_uint64() function.