Skip to content

harden: disable external XML entity processing in... #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anupamme wants to merge 1 commit into from
+10 −5
Closed

harden: disable external XML entity processing in... #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/scripts/generate_sitemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import os
from lxml import etree
import defusedxml.ElementTree as ET

REPO_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), '../../'))
BASE_URL = "https://onsdigital.github.io/Charts/"
SITEMAP_PATH = os.path.join(REPO_ROOT, "sitemap.xml")

NS = "http://www.sitemaps.org/schemas/sitemap/0.9"
ET.register_namespace('', NS)

# List of folders to include (those with index.html)
folders = [
d for d in os.listdir(REPO_ROOT)
Expand All @@ -18,14 +21,16 @@
urls.append(BASE_URL + folder + "/index.html")

# Create XML
urlset = etree.Element("urlset", xmlns="http://www.sitemaps.org/schemas/sitemap/0.9")
urlset = ET.Element(f"{{{NS}}}urlset")
for url in urls:
url_elem = etree.SubElement(urlset, "url")
loc = etree.SubElement(url_elem, "loc")
url_elem = ET.SubElement(urlset, f"{{{NS}}}url")
loc = ET.SubElement(url_elem, f"{{{NS}}}loc")
loc.text = url

# Write to file
ET.indent(urlset)
tree = ET.ElementTree(urlset)
with open(SITEMAP_PATH, "wb") as f:
f.write(etree.tostring(urlset, pretty_print=True, xml_declaration=True, encoding="UTF-8"))
tree.write(f, xml_declaration=True, encoding="UTF-8")

print(f"Sitemap generated at {SITEMAP_PATH}")