Skip to content

added bar-chart-with-context bubbles templte - #397

Open
broadpeter wants to merge 3 commits into
mainfrom
chart/bar-chart-with-context-bubbles
Open

added bar-chart-with-context bubbles templte#397
broadpeter wants to merge 3 commits into
mainfrom
chart/bar-chart-with-context-bubbles

Conversation

@broadpeter

Copy link
Copy Markdown
Contributor

Added this chart type as it's been used in a a few releases now

@henryjameslau

Copy link
Copy Markdown
Contributor

Don't forget the chart menu

@broadpeter

Copy link
Copy Markdown
Contributor Author

@henryjameslau I always do. have added now

@henryjameslau

Copy link
Copy Markdown
Contributor

What's the difference between xAxisTitle and xAxisLabel?

.attr("fill", (d) => d.value >= 0 ? config.colourPalettePositive : config.colourPaletteNegative);

// Add context bubbles
const maxRadius = margin.bubble / 1.85;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a config parameter to change the relative scaled size of the bubbles?

@broadpeter

Copy link
Copy Markdown
Contributor Author

What's the difference between xAxisTitle and xAxisLabel?

X axis title goes at the top left
X axis label as usual bottom right.
Title is additional to differentiate from the bubbles

@henryjameslau

Copy link
Copy Markdown
Contributor

What's the difference between xAxisTitle and xAxisLabel?

X axis title goes at the top left X axis label as usual bottom right. Title is additional to differentiate from the bubbles

So is their contents the same?

@broadpeter

Copy link
Copy Markdown
Contributor Author

@henryjameslau

Copy link
Copy Markdown
Contributor
{5BC7A13D-3DF7-4F0D-8AE2-D3A4E2B83E09}

@henryjameslau

henryjameslau commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

hmm, "Percentage" is the units. "Online spending as proportion of spend" is the label. You could use the title as both as the axis ticks have % in them already. Will someone please read the service manual

Axis number labels
When displaying percentages or monetary values on a chart, always include the relevant symbols (% or currency symbols) directly in the axis labels. This helps users to understand and interpret the chart quickly.

@henryjameslau

Copy link
Copy Markdown
Contributor

I meant you could do it as "Online spending as proportion of spend (%)" at the top since there's no % sign up there. But there's no reason why they couldn't be the same.

If needed, you can also specify the unit in the axis title. For all other types of unit, include the unit only in the axis title and/or chart subtitle, not in the axis labels.

@broadpeter

Copy link
Copy Markdown
Contributor Author

Yep. I guess just the rationale is because of the bubbles you may need additional text in that position as well as the bottom. It may or may not be the same. Is the main issue just labelling the config in a way that is clear?

@henryjameslau

Copy link
Copy Markdown
Contributor

I wonder whether we need the axis on the top as well so it help you read it other you're scrolling down to the bottom. I get you're trying to do two different thing so you need to say what the range is doing vs the bubble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants