New template:slope chart ✨ + adjust helpers - #387
Open
henryjameslau wants to merge 7 commits into
Open
Conversation
Open
Contributor
Author
|
Ready for review @sam-ctrl |
nrennie
approved these changes
Jun 24, 2026
nrennie
left a comment
Contributor
There was a problem hiding this comment.
I've fixed the conflicts and I'm happy with the code.
Contributor
|
@broadpeter Are you happy with the style on this template? Any changes?
|
Contributor
|
Needs colour contrast boost to 1:4.5 on the regular weight text. I will try to add. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Key changes to createDirectLabels helper function, in the options object: - labelStrategy can be set as 'firstLast'
I've also had so create a new wrapStyled function which wraps text elements with nested tspans for situations where you want one tspan to be bold like in the slope chart design.
Addresses #356
Please review for style @broadpeter, and for functionality anyone else.