fix(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4#197
fix(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4#197dependabot[bot] wants to merge 2 commits into
Conversation
athena-omt
left a comment
There was a problem hiding this comment.
Request changes: update test/security-workflow.test.ts to expect ossf/scorecard-action@v2.4.4. The PR changes .github/workflows/scorecard.yml to v2.4.4, while the adjacent contract test still asserts v2.4.3 at lines 47–49. This fails both CI test jobs and leaves the required CI Gate blocked.
4f00b79 to
8b92f03
Compare
athena-omt
left a comment
There was a problem hiding this comment.
Request changes: update test/security-workflow.test.ts to expect ossf/scorecard-action@v2.4.4. This PR changes .github/workflows/scorecard.yml to v2.4.4, while the adjacent contract assertion at lines 47–49 still requires v2.4.3. On the current head, pnpm exec vitest run test/security-workflow.test.ts --reporter=verbose fails at that assertion; the fresh CI test, lume macos contract, Fast Checks, and CI Gate checks are consequently blocked. Repair handoff: update the assertion and rerun the targeted test plus CI.
athena-omt
left a comment
There was a problem hiding this comment.
The repair at this head is correct: test/security-workflow.test.ts now expects ossf/scorecard-action@v2.4.4, matching .github/workflows/scorecard.yml. The exact-head diff is limited to that contract assertion, and its completed CI checks are green. However, main advanced to cb517b242db31643a93545053d8e395ca9c795ce after this head's CI began; the PR still reports base 5556b622b814dd3b15830816f393997e0a402f63. Please update/rebase the branch onto current main, wait for fresh CI, and reroute for review at the new head.
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.3 to 2.4.4. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@v2.4.3...v2.4.4) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-version: 2.4.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Daedalus <Daedalus-omt@protonmail.com> Signed-off-by: Daedalus <268206840+daedalus-omt@users.noreply.github.com>
228fb41 to
83ac2be
Compare
athena-omt
left a comment
There was a problem hiding this comment.
The repair is correct: the Scorecard workflow and its adjacent contract test both reference ossf/scorecard-action@v2.4.4. I reviewed the exact-head diff and ran bash scripts/ci/run-fast-checks.sh locally: lint, 315 tests, and build passed. However, the live Fast Checks job failed and the required CI Gate consequently failed on this same head. No source change is requested; please rerun PR Fast CI and investigate the runner failure if it recurs, then reroute for review.
Bumps ossf/scorecard-action from 2.4.3 to 2.4.4.
Release notes
Sourced from ossf/scorecard-action's releases.
Commits
2d11466Bump action tag for v2.4.4 release (#1688)1bd3285🌱 Bump the docker-images group across 1 directory with 2 updates (#1...913edce🌱 Bump github.com/containerd/containerd from 1.7.32 to 1.7.33 (#1671)0957b8f🌱 Bump golang.org/x/net from 0.56.0 to 0.57.0 (#1680)f0061eb🌱 Bump google.golang.org/grpc from 1.81.1 to 1.82.1 (#1687)20ee732🌱 Bump github.com/sigstore/cosign/v2 from 2.6.3 to 2.6.4 (#1685)9f295ef🌱 Bump the github-actions group with 6 updates (#1686)69bf556🌱 Bump github.com/sigstore/sigstore-go from 1.1.4 to 1.2.0 (#1681)94e8b96🌱 Bump github.com/sigstore/rekor from 1.5.0 to 1.5.2 (#1673)c7a1b37🌱 Bump github.com/sigstore/fulcio from 1.8.5 to 1.8.6 (#1675)