Fix Lume SSH readiness detection#193
Open
jmcte wants to merge 1 commit into
Open
Conversation
Comment on lines
+265
to
+284
| const result = spawnSync( | ||
| "bash", | ||
| [ | ||
| "-c", | ||
| [ | ||
| 'source "$1"', | ||
| 'log() { printf "%s\\n" "$*" >&2; }', | ||
| 'LUME_VM_NAME=macos-runner-slot-01', | ||
| 'GUEST_USER=lume', | ||
| 'GUEST_PASSWORD=test-password', | ||
| "wait_for_ssh", | ||
| ].join("\n"), | ||
| "bash", | ||
| path.resolve("scripts/lume/lib.sh"), | ||
| ], | ||
| { | ||
| encoding: "utf8", | ||
| env: { ...process.env, PATH: `${directory}:${process.env.PATH ?? ""}` }, | ||
| }, | ||
| ); |
jmcte
marked this pull request as ready for review
July 22, 2026 22:55
athena-omt
approved these changes
Jul 22, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Reviewed current head 57e20fb. The readiness path now requires both a zero exit status and empty Lume SSH probe output, so the zero-exit “no IP address” response remains in the retry loop before guest bootstrap. I verified the run-slot call path and added regression coverage. Local shell syntax and diff checks passed; a dependency-free probe confirmed silent success returns 0 and the false-ready response returns 1. The isolated worktree lacks Vitest, but fresh CI test and Lume macOS contract checks are successful. Approved.
athena-omt
enabled auto-merge (squash)
July 22, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no IP addressresponse from starting guest bootstrap before SSH is usable.Governing Issue
Refs OMT-Global/lattice#709.
Validation
bash -n scripts/lume/lib.sh scripts/lume/run-slot.sh scripts/lume/create-slot.shno IP addressresponse returns 1 and logs the retry.git diff --checkpnpm exec vitest run test/lume-scripts.test.ts— unavailable because this clean worktree has no Vitest and the lockfile-pinnedpnpm install --frozen-lockfilestopped on package-signature verification. The install was not bypassed.Bootstrap Governance
Merge Automation
Notes