feat: harden public provenance boundaries - #112
Conversation
Exact-head validation evidenceValidated head:
The sole exact-head CI failure is The fail-closed autoreview scanner rejected the literal historical credential-shaped fixtures on the deleted side of the original whole-branch patch, so that blocked bundle was not sent. A behavior-neutral first commit sanitizes those fixture expressions; the entire substantive code, test, documentation, and ADR diff after that commit received the clean reviews above. |
athena-omt
left a comment
There was a problem hiding this comment.
Reviewed exact head 65dac73. The v2 provenance boundary is strict and the CLI routes through it; the focused provenance suite and full local check pass (23 files, 209 tests). Live main is the PR base, and no reviews or inline review comments are present. This material PR cannot be approved yet: Validate PR Governance and CI Gate fail with PRS-INDEPENDENT-REVIEW-001 because there is no approving reviewer other than the author. Required next owner: an independent reviewer should approve this exact head; the pull_request_review trigger will then rerun governance CI.
athena-omt
left a comment
There was a problem hiding this comment.
Approved for exact head 65dac73. I independently reviewed the v2 provenance boundary and call paths: strict typed metadata allowlisting, schema-bound redaction evidence, and legacy parsing are coherent. Local exact-head validation passed: tests/provenance.test.ts (18 tests), TypeScript typecheck, build, and git diff --check. No unresolved review threads. Auto-merge is already enabled; governance CI should rerun for this approval.
Restrict public metadata to an explicit schema allowlist, reject unknown and credential-shaped identity fields, validate exact redaction evidence, and document the confirmed provenance threat model. Emit and validate strict version-2 manifests, retain version 1 behind an explicit hardened historical reader, and record the remote-sink hard stops required by issue #61. Signed-off-by: Pheidon <pheidon@omt-assist.org>
65dac73 to
c0ca88d
Compare
pheidon
left a comment
There was a problem hiding this comment.
Pheidon second-pass approval for exact head c0ca88d. Rechecked the full provenance tree, strict v2 boundary, explicit legacy reader, threat-model scope, credential/redaction tests, and fresh CI after replaying the reviewed changes onto merged main. Validate PR Governance and CI Gate pass on this exact head.
Summary
Governing Issue
Refs #61. This is the local public-contract and threat-model slice; it does not close the encrypted private provenance, remote sink, audited-read, retention, signing-unification, or material-gate acceptance criteria.
Validation
TMPDIR=/tmp npm run check— 23 test files, 209 tests passed.npm run build— passed.git diff --check origin/main...HEAD— passed.The fail-closed autoreview scanner cannot ingest the full
origin/main...HEADpatch because the first behavior-neutral commit removes two historical credential-shaped fixture literals from the old side of the diff. No blocked bundle was sent. The two-line fixture change only composes the same runtime values; the complete behavioral/code/documentation diff after that sanitation commit received the clean final review.Bootstrap Governance
Material change: yes
ADR: docs/decisions/ADR-0006-public-provenance-v2.md
Merge Automation
Notes
policy,generator,aiProvider,aiModel,promptHash, andchangeClass.readLegacyPublicProvenanceis an explicit historical-read path and is not a publication gate.