feat: add ability to expand/collapse editor plugins sidebar (closes #93)#94
Open
danyill wants to merge 2 commits into
Open
feat: add ability to expand/collapse editor plugins sidebar (closes #93)#94danyill wants to merge 2 commits into
danyill wants to merge 2 commits into
Conversation
danyill
commented
Mar 22, 2026
| class="toggle-sidebar" | ||
| role="button" | ||
| tabindex="0" | ||
| @click=${() => { |
Contributor
Author
There was a problem hiding this comment.
The linter demanded I do this.
danyill
commented
Mar 22, 2026
| :host([expanded]) { | ||
| width: var(--editor-plugins-panel-width); | ||
| .toggle-sidebar { | ||
| margin-left: 12px; |
Contributor
Author
There was a problem hiding this comment.
I expect this is not generic with change in icon size...
danyill
commented
Mar 22, 2026
| display: flex; | ||
| align-items: center; | ||
| min-height: 56px; | ||
| padding-left: calc(var(--editor-plugins-panel-item-leading-space) - 6px); |
Contributor
Author
There was a problem hiding this comment.
I expect these two lines are likely not generic with change in icon size...
danyill
commented
Mar 22, 2026
Contributor
Author
danyill
left a comment
danyill
left a comment
There was a problem hiding this comment.
A few small notes.
danyill
commented
Mar 23, 2026
| @@ -78,6 +82,7 @@ export class EditorPluginsPanel extends ScopedElementsMixin(LitElement) { | |||
| <div class="footer"> | |||
Contributor
Author
There was a problem hiding this comment.
I suppose I could have tried to include this as an oscd-list-item which would avoid perhaps some styling consistency issues but I shall await review. Might create more issues (placing at the bottom) than it would solve.
danyill
force-pushed
the
issue-93-fold-editors
branch
from
9a8d739 to
1f15191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wonder if this is close to acceptable (closes #93)
The CSS rules are not quite enough for generic icon sizes controlled by variables...
As a drive by since code test coverage was so high I added something for the menu bar appIcon (which I only recently discovered).
I've tried to make the component control it's own state without requiring anything from oscd-shell.