Skip to content

Fix missing search box dimensions on prerendered pages #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierosavi merged 1 commit into from
Oct 12, 2026
Merged

Fix missing search box dimensions on prerendered pages #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/islands/device-search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { unsafeHTML } from "lit/directives/unsafe-html.js";
import type { Ref } from "lit/directives/ref.js";

import { getDevices } from "../io/device.js";
import { getDimensions } from "../io/dimension.js";
import { m } from "../paraglide/messages.js";
import { localizeHref } from "../paraglide/runtime.js";
import {
Expand Down Expand Up @@ -89,6 +90,7 @@ export class DeviceSearch extends LitElement {

private _fetchTimer?: ReturnType<typeof setTimeout>;
private _fetchAbort?: AbortController;
private _dimensionsAbort?: AbortController;

// server-rendered elements that are enhanced
private _form: HTMLFormElement | null = null;
Expand Down Expand Up @@ -125,6 +127,11 @@ export class DeviceSearch extends LitElement {

this._clearButton?.addEventListener("click", this._onClearButtonClick);
this._form?.addEventListener("submit", this._onFormSubmit);

// prerendered pages can't reach the api at build time and ship without dimensions
if (this.dimensions === null) {
void this._fetchDimensions();
}
}

override disconnectedCallback(): void {
Expand All @@ -137,6 +144,7 @@ export class DeviceSearch extends LitElement {
this._clearButton?.removeEventListener("click", this._onClearButtonClick);
this._form?.removeEventListener("submit", this._onFormSubmit);

this._dimensionsAbort?.abort();
this._resetFetched();
}

Expand Down Expand Up @@ -363,6 +371,21 @@ export class DeviceSearch extends LitElement {
}
}

private async _fetchDimensions() {
this._dimensionsAbort?.abort();
const controller = new AbortController();
this._dimensionsAbort = controller;

try {
const { dimensions } = await getDimensions({}, controller.signal);
this.dimensions = dimensions;
} catch (e) {
if (!isAbortError(e)) {
console.error(e);
}
}
}

private _resetFetched(): void {
clearTimeout(this._fetchTimer);
this._fetchAbort?.abort();
Expand Down
Loading