Repository navigation
[20.0][FIX] web_dialog_size: show a single expand button in the full composer - #3763
cristina-hidalgo-tecnativa wants to merge 1 commit into
Conversation
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
I also see two buttons in other dialogs, for example, when you use Create and edit... in a many2one field:
This makes me think that Odoo already supports this in the core Dialog, but only displays the button when onExpand is defined:
https://github.com/odoo/odoo/blob/dd797414fa250a039c6bf494cfb281d67b4bf83c/addons/web/static/src/core/dialog/dialog.xml#L39
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
I'm not sure whether resizing the dialog re-renders the whole view and reloads the record, but when I try to add a custom filter, this popup is very slow. Other dialogs work fine, but this one is very slow.
Could you check this? Or is this standard Odoo behavior?
2026-10-28.09-37-29.mp4
I noticed the URL has Could you check whether it's still slow without |
OK, I tested it without debug mode in three different environments, in this order: Odoo runbot, locally, and OCA runboat. On runbot, even with network latency, it works fine: I dragged and dropped the popup, and it rendered quickly. 2026-10-28.11-09-36.mp4Anyway, please check my other comment: |
|
I think it has to do with being |
You're right! With |
3fd0747 to
4b4b466
Compare
In "Create and edit..." the two buttons do different things: the core one (shown because You're right that |
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
In short, we're going back to the original icons instead of using the Odoo icons, to avoid displaying the same icon twice.
In some dialogs, two different icons are displayed; this could be added to the ROADMAP. Anyway, it works in the full composer, which was the initial request, so let's move forward to avoid blocking this.
4b4b466 to
0fc24ac
Compare

Odoo added an expand/compress button to the full message composer (odoo/odoo#242468), with its own state. This module already adds one to every dialog, so the composer showed two buttons, and with
web_dialog_size.default_maximizeenabled Odoo's icon didn't match the dialog size.fssize and icons (expand_content/close_fullscreen).Core's button only exists in
ActionDialog, so extending it wouldn't cover the other dialogs.@Tecnativa TT64890
@pedrobaeza @carlos-lopez-tecnativa