Repository navigation
[16.0][IMP] web_widget_sub_view: configurable create-action type and fix overlapping content - #3752
Open
juanalfonsocb wants to merge 1 commit into
Open
juanalfonsocb wants to merge 1 commit into
juanalfonsocb wants to merge 1 commit into
Conversation
…erlapping content
OCA-git-bot
added
series:16.0
mod:web_widget_sub_view
juanalfonsocb
changed the title
juanalfonsocb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
create-actiontype configurable + fix vertical-notebook overlapcreate-actioncould be a method name or an action id, but the widget always treated it as an action id (type: "action"hardcoded), breaking the method-name case (KeyError: False). Addedcreate-action-type(object/action, defaultobject) to pick the right one.Also fixed the widget's content rendering on top of the tabs sidebar when nested in a vertical notebook (forced
position: staticon.o_content, reset margins meant for horizontal sheets).Breaking: default changed to
object— existingcreate-actionusers needcreate-action-type="action"explicitly.