Repository navigation
Conversation
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the chatter is shown below the form (attachment preview on a wide screen, or a screen below 1534px), the module falls back to that chatter and still sets the 30% width on it. The chatter gets squeezed and its topbar scrolls horizontally.
Now it only acts on the side chatter (
.o-aside) and clears its inline styles when the layout switches.To reproduce: install
accountandweb_toggle_chatter, open a draft vendor bill with a PDF attached on a screen of at least 1534px.Note: this can't be reproduced on the runboat build, since
web_responsivedisables the attachment preview (hasFile()returns false).