Repository navigation
[17.0][FIX] web_responsive: declare _assets_primary_variables as a list - #3740
Merged
Merged
Conversation
sersanchus
approved these changes
Oct 19, 2026
ljmnoonan
approved these changes
Oct 19, 2026
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at fca94d5. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web._assets_primary_variableswas declared with{...}, which is a Pythonset, not a list. Odoo iterates it without complaining, but a set of strings has no stable order (string hashing is randomized per process), so the order of the two SCSS files in the bundle can change between restarts or workers.Every other bundle in the manifest, and in Odoo itself, uses a list.
The same
setis present in 18.0 and 19.0. Once this is merged I'll forward-port it there. From what I can see, this has been fixed in the migration to version 20.0