Repository navigation
[ADD] web_theme_focus: minimal focus backend theme - larger icons, hidden search, transparent navbar - #3648
[ADD] web_theme_focus: minimal focus backend theme - larger icons, hidden search, transparent navbar#3648volkantasci wants to merge 1 commit into
Conversation
3064e1d to
9dede9a
Compare
|
Thanks for the catch @tarteo — the copied artwork is gone.
Also, per the earlier review feedback, the branch is squashed to a single |
|
Hi @tarteo 👋 Following up on your review — the Enterprise-derived artwork is gone. In commit
All checks are green (pre-commit, Odoo/OCB tests, codecov, runboat) and the PR is a single squashed commit. Could you take another look when you have a moment? Thanks! |
9dede9a to
5c41389
Compare
|
Hi @tarteo 👋 I've rebased the branch onto the latest Could you take another look when you have a moment? Thanks! |
|
Hi @tarteo 👋 — gentle reminder: the changes you requested are in place ( |
|
Hi @pedrobaeza 👋 — the changes requested by @tarteo have been addressed ( |
|
I think he's on holidays. Let's wait till next week. |
tarteo
left a comment
There was a problem hiding this comment.
This is my last review for this PR, I won't spend more time reviewing code entirely generated by AI. Otherwise I might as well just let my AI review your AI's code. The same applies for AI generated replies.
|
|
||
| apps_menu_theme = fields.Selection( | ||
| selection_add=[("focus", "Focus")], | ||
| ondelete={"focus": "cascade"}, |
There was a problem hiding this comment.
On uninstall this will delete users that use this theme
cbebf19 to
91aa02b
Compare
|
Thanks for the heads-up, @pedrobaeza 🙏 — we'll wait until next week then. In the meantime I've fixed the pre-commit formatting on the latest commit ( |
91aa02b to
7ea6ef4
Compare
What does this PR do?
Adds the
web_theme_focusaddon: a new Focus option forweb_responsive's app-menu theme picker (⚙ Apps Menu Preferences → Theme).res.users.apps_menu_themegains thefocusselection value.web.assets_web_darkso they only load under the dark color scheme (requiresweb_dark_mode).session.apps_menu.themeon<body data-app-theme>from aWebClient.setuppatch, so CSS can reach the navbar and the app-menu container, which live outside.o_grid_apps_menu.The module does not aim to fully replicate Odoo Enterprise and explicitly excludes
web_enterprise.Tests
test_selection_includes_focus/test_user_can_be_set_to_focus: the selection value exists and is assignable.test_dark_bundle_registers_focus_assets:web.assets_web_darkresolves both focus.dark.scssfiles.test_webclient_bootstrap_renders: the webclient bootstrap page renders (HTTP 200) with the module installed.test_session_info_reports_focus_theme: a user withapps_menu_theme=focusreceivesapps_menu.theme == "focus"in the webclient session info.All 5 tests pass against a live Odoo 19.0 run (
0 failed, 0 error(s) of 5 tests), with bothweb.assets_web.min.cssandweb.assets_web_dark.min.csscompiling successfully.Screenshots
The gradient artwork (
app_switcher_background_light.svg/_dark.svg) is clean-room reconstructed — no proprietary Enterprise source is copied.Notes to reviewers
i18n/tr.po("Focus" → "Odak"), mirroring howweb_responsivetranslates "Milk"/"Community"..dark.scssrules are defined onbody[data-app-theme="focus"]; the compiled dark bundle places them after the embedded light rules, so the dark gradient/text colors win as intended (verified in the compiled bundle).web,web_dark_mode,web_responsive; the theme piggy-backs on web_responsive'sapps_menusession info, preferences dialog,reload_contextflow and.o_apps_menu_openedbody class.