Repository navigation
[19.0][FIX] base_tier_validation_correction: revert message lists restored reviewers only - #102
Open
twtrubiks wants to merge 1 commit into
Conversation
…reviewers only The correction and revert messages listed the reviewers of all the reviews of the item, including reviews approved in the meantime and left untouched. Only list the reviews actually changed, and post nothing when none was. Fixes OCA#101
Contributor
|
Hi @kittiu, |
OCA-git-bot
added
series:19.0
mod:base_tier_validation_correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
When a correction is reverted, the message on the document listed the reviewers of all the reviews of the item, including reviews approved after the correction, which the revert leaves untouched. A document approved by the new reviewer then said it was reverted "back to" that reviewer.
The correction and revert messages now only list the reviews actually changed, and the reviewers they were set to. Nothing is posted when no review was changed.
Two new tests: one with an approved and a pending review, one where every review was approved. Both fail without the fix.