[18.0][IMP] storage_backend: add storage category + limit swap by category#633
Open
simahawk wants to merge 5 commits into
Open
[18.0][IMP] storage_backend: add storage category + limit swap by category#633simahawk wants to merge 5 commits into
simahawk wants to merge 5 commits into
Conversation
OCA-git-bot
added
series:18.0
mod:storage_file
simahawk
changed the title
simahawk
force-pushed
the
18-backend-category
branch
2 times, most recently
from
c2b7bfb to
0a2e3f7
Compare
A way to classify storages in a functional way. For instance: you might have N storage backends for the shop, N storage backends for data import, N storage backends for EDI purposes. With this change you can finally organize them and let your customers understand what such storages do.
Is not allowed to swap files to a backend of a different category. A technical door is left opened in case for specific reasons you want force file swap by using the ctx key swap_backend_bypass_category_check.
simahawk
force-pushed
the
18-backend-category
branch
from
0a2e3f7 to
0cb1fd2
Compare
OCA-git-bot
added
mod:storage_media
|
Is this work ready for review? I would suggest renaming the PR to indicate that the changes affect several addons. Also, the commit history could benefit from some squashing. |
rrebollo
reviewed
Jun 13, 2026
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Pretty solid development. I would suggest mentioning the feature in some of the addon's documentation. Also, please address the commit organization issues. Once that's done, feel free to ping me and I'll approve.
Also, please consider reviewing my contribution (#634) in return.
| "storage.backend.category", | ||
| related="source_backend_id.categ_id", | ||
| string="Source Backend Category", | ||
| readonly=True, |
There was a problem hiding this comment.
Suggested change
| readonly=True, |
It's default for related fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A way to classify storages in a functional way.
For instance: you might have N storage backends for the shop,
N storage backends for data import, N storage backends for EDI purposes.
With this change you can finally organize them
and let your customers understand what such storages do.
On top of that, swapping files is now limited by category.