Skip to content

[19.0][IMP] fs_folder: Disable FsFolderItem clicks while processing#626

Open
quoc-pn wants to merge 1 commit into
OCA:19.0from
komit-consulting:19.0-fs_folder-FsFolderItem-rapid-click-lock
Open

[19.0][IMP] fs_folder: Disable FsFolderItem clicks while processing#626
quoc-pn wants to merge 1 commit into
OCA:19.0from
komit-consulting:19.0-fs_folder-FsFolderItem-rapid-click-lock

Conversation

@quoc-pn

@quoc-pn quoc-pn commented May 29, 2026

Copy link
Copy Markdown
Member

Summary

Fix race conditions in FsFolder by preventing overlapping FsFolderItem actions from rapid clicks.

image

What changed

  • Added a single in-flight lock in FsFolder state.
  • Routed item actions through the parent lock so only one action runs at a time.
  • Released the lock in all cases (success or failure).

Result

  • No duplicate item actions from double/rapid clicks.
  • View interaction is restored reliably after each action.

@quoc-pn quoc-pn marked this pull request as ready for review May 29, 2026 10:25

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @quoc-pn Fot the fix. I'm no a JS specialist.... so I'll take time to analyse your change and see if it's the right pattern (at least for my internal knowledge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants