[18.0][MIG] stock_available_mrp: Migration to 18.0 by StefanRijnhart · Pull Request #68 · OCA/stock-logistics-availability

StefanRijnhart · 2025-12-22T10:15:28Z

Superseding #38

Replace product type 'product' by 'consu' + is_storable
Apply fields.Command where possible
Rebase to include [FIX] stock_available_mrp: increment potencial_qty to immediately_usable_qty instead of replacing it #32
Squash administrative commits somewhat
Remove unused config parameter
Improve config settings description in a separate commit so it can be picked into 17 if desired
Fix 'configuration parameter configured in settings UI is actually unused', also in a separate commit for backporting
Fix issue where variant specific BoM was not preferred, by @dcatarino
Fix issue with quantities of kit products, by @ellbristow

StefanRijnhart · 2025-12-22T11:20:51Z

/ocabot migration stock_available_mrp

ellbristow

This caused problems for one of our customers who send the immediately usable quantity to Magento via EDI and it was sending the wrong stock figures.

ellbristow · 2026-02-06T11:02:55Z

+                )
+
+            res[product.id]["potential_qty"] = potential_qty
+            res[product.id]["immediately_usable_qty"] += potential_qty


In the case of Kits this is wrong. Odoo already includes the buildable quantity upstream, so this modification is adding additional stock (double counting the Available stock). By returning this to = and limiting this to Kits, both kits and manufactured show the correct Available qty.

Suggested change

res[product.id]["immediately_usable_qty"] += potential_qty

if bom_id.type == "phantom":

res[product.id]["immediately_usable_qty"] = potential_qty

Apologies for the late response and thank you very much for suggesting the fix. Added in a separate commit.

github-actions · 2026-06-07T14:03:57Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@gdgellatly

Compute potential quantities for both product templates and variants. To keep the code simple, only the biggest potential of any single variant is accounted for in the template's potential. Take all levels of phantom BoM into account, respects validity dates etc. thanks to the use of the standard method _bom_explode, as suggested by @gdgellatly in OCA/stock-logistics-warehouse#5 (comment) Improve tests, rewritten in python. Adhere to new file/manifest/README conventions. Simplify copyright headers

sudo is not required since mrp.bom are readable to groups with access to the qty_x fields on a product. Moreover using sudo to retrive the bom will ignore the company_id defined on the bom

Record rules used to not be checked on stock quants, but now they are since Odoo's commit 2fd14db57433d08ab368a7e18d18ae8d49dafab1 (odoo/odoo@2fd14db). In our test we changed the company of the products and BoMs but we neglected that the stock was not attached to the right company, and that made the test fail. To fix that, make the test inventory for the right company. Since there is a little inconsistency in the demo data with a negative quantity of an unrelated product, use the `partial` filter for the inventories instead of the `none` filter, so that no wrong inventory lines are added automatically.

…ch field use to compute potential

…ew + small improvements

Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_available_mrp/ca/

Currently translated at 100.0% (10 of 10 strings) Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/

Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/es/

Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-availability-16.0/stock-logistics-availability-16.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-16-0/stock-logistics-availability-16-0-stock_available_mrp/it/

When a BoM is linked just to one variant through field `product_id`, it is taken in account when computing stock of the rest of variants of the same template.

Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-availability-17.0/stock-logistics-availability-17.0-stock_available_mrp Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-availability-17-0/stock-logistics-availability-17-0-stock_available_mrp/it/

…ble_qty instead of replacing it

…ameters The configuration parameter in which the field to use was stored was actually not used. Instead, another configuration parameter, for which a default value was provided in xml data was used.

Use variant-specific BoMs when computing potential stock, including nested phantom BoMs, instead of selecting the first template BoM.

… for kit products Co-authored-by: Elliott Bristow <elliott@glo.systems>

StefanRijnhart force-pushed the 18.0-mig-stock_available_mrp branch 8 times, most recently from c460a23 to 46b084b Compare December 22, 2025 11:13

StefanRijnhart marked this pull request as ready for review December 22, 2025 11:20

StefanRijnhart mentioned this pull request Dec 22, 2025

[18.0][MIG] stock_available_mrp: Migration to 18.0 #38

Closed

OCA-git-bot added this to the 18.0 milestone Dec 22, 2025

OCA-git-bot mentioned this pull request Dec 22, 2025

Migration to version 18.0 #29

Open

7 tasks

StefanRijnhart force-pushed the 18.0-mig-stock_available_mrp branch 4 times, most recently from 5151f39 to 093f7a0 Compare December 22, 2025 19:40

ellbristow suggested changes Feb 6, 2026

View reviewed changes

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 7, 2026

OCA-git-bot added series:18.0 mod:stock_available_mrp Module stock_available_mrp labels Jun 8, 2026

sbidoul and others added 8 commits June 8, 2026 14:54

[MOV] move addons out of __unported__ (they remain not installable)

c1d7b12

[FIX] Browse mrp.bom as current user

663bd1c

sudo is not required since mrp.bom are readable to groups with access to the qty_x fields on a product. Moreover using sudo to retrive the bom will ignore the company_id defined on the bom

OCA Transbot updated translations from Transifex

df435b0

stock_available_mrp: fix BOM qty (multi-units, efficiency)

ace9902

stock_available / stock_available_mrp : add possibility to choose whi…

adb8d0b

…ch field use to compute potential

[FIX+IMP] stock_available_mrp: fix recursive potential_qty in list vi…

f3ffdef

…ew + small improvements

rousseldenis and others added 14 commits June 8, 2026 14:54

[TESTS] stock_available_mrp: Add test for phantom bom

52f4d22

stock_available_mrp 15.0.1.0.1

8875f76

Added translation using Weblate (Catalan)

56f78f5

[16.0][MIG] stock_available_mrp: Migration to 16.0

453b0be

[IMP] stock_available_mrp: pre-commit auto fixes

cd8b8b4

[MIG] stock_available_mrp: Migration to 17.0

52926f3

[FIX] stock_available_mrp: variant BoMs

8ef194a

When a BoM is linked just to one variant through field `product_id`, it is taken in account when computing stock of the rest of variants of the same template.

[FIX] stock_available_mrp: increment potencial_qty to immediately_usa…

2696d71

…ble_qty instead of replacing it

StefanRijnhart force-pushed the 18.0-mig-stock_available_mrp branch 2 times, most recently from 806bb22 to 7c1e45c Compare June 8, 2026 12:55

This was referenced Jun 8, 2026

[MIG] stock_available_mrp - Migrated to V18 #71

Closed

[16.0][FIX] stock_available_mrp: avoid infinite recursion on sibling-variant kits #77

Open

StefanRijnhart and others added 5 commits June 8, 2026 15:34

[IMP] stock_available_mrp: pre-commit auto fixes

bd10345

[MIG] stock_available_mrp: Migration to 18.0

218a817

[IMP] stock_available_mrp: improve configuration setting description

e682ac2

[FIX] stock_available_mrp: clear up confusion about configuration par…

50447de

…ameters The configuration parameter in which the field to use was stored was actually not used. Instead, another configuration parameter, for which a default value was provided in xml data was used.

[FIX] stock_available_mrp: prefer product-specific BoMs

472a6ae

Use variant-specific BoMs when computing potential stock, including nested phantom BoMs, instead of selecting the first template BoM.

StefanRijnhart force-pushed the 18.0-mig-stock_available_mrp branch 3 times, most recently from 779397f to 7f0c794 Compare June 8, 2026 13:41

[FIX] stock_available_mrp: Odoo already provides buildable quantities…

728d4b3

… for kit products Co-authored-by: Elliott Bristow <elliott@glo.systems>

StefanRijnhart force-pushed the 18.0-mig-stock_available_mrp branch from 7f0c794 to 728d4b3 Compare June 8, 2026 13:42

dcatarino approved these changes Jun 8, 2026

View reviewed changes

github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] stock_available_mrp: Migration to 18.0#68

[18.0][MIG] stock_available_mrp: Migration to 18.0#68
StefanRijnhart wants to merge 58 commits into
OCA:18.0from
StefanRijnhart:18.0-mig-stock_available_mrp

StefanRijnhart commented Dec 22, 2025 •

edited

Loading

Uh oh!

StefanRijnhart commented Dec 22, 2025

Uh oh!

ellbristow left a comment

Uh oh!

ellbristow Feb 6, 2026

Uh oh!

StefanRijnhart Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	res[product.id]["immediately_usable_qty"] += potential_qty
	if bom_id.type == "phantom":
	res[product.id]["immediately_usable_qty"] = potential_qty

Uh oh!

Conversation

StefanRijnhart commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanRijnhart commented Dec 22, 2025

Uh oh!

ellbristow left a comment

Choose a reason for hiding this comment

Uh oh!

ellbristow Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

StefanRijnhart commented Dec 22, 2025 •

edited

Loading