[18.0][FIX] rma: Fix can_be_replaced value

[victoralmau]

Fix can_be_replaced value

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa

[OCA-git-bot]

Hi @chienandalu, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

[carlos-lopez-tecnativa]

I think you need to add a bit more context to explain the change or provide a real use case. Does this change come from a customer-specific need, or is it part of a general requirement/flow?

[victoralmau]

This change is not based on a customer requirement; it is simply intended to ensure consistency:

• If the RMA is in the “Awaiting Replacement” status (the replacement has already been generated), the “Replace” button should not appear, and it should not be possible to create a new one.
• If the RMA is in the “Replaced” status (the replacement has already been generated and validated), the ‘Replace’ button should not appear, and it should not be possible to create a new one; the process is already “completed.”

[pedrobaeza]

Do you know any reason why it was that way before?

[victoralmau]

No, I don't know why it's like that right now; maybe someone can explain it to us.

[carlos-lopez-tecnativa]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-588-by-pedrobaeza-bump-patch, awaiting test results.

[pedrobaeza]

@sbejaoui this change makes sense, but don't know if there's any of your flows that require the previous condition.

[OCA-git-bot]

Congratulations, your PR was merged at e4cb652. Thanks a lot for contributing to OCA. ❤️

[sbejaoui]

LGTM thanks