[IMP] rma_sale: manually link RMAs to sale orders#585
Open
sbejaoui wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @pedrobaeza, |
In some cases, RMAs need to be created before the related sale order is known. This commit allows manually linking the RMA to a sale order afterward to improve traceability
sbejaoui
force-pushed
the
16.0-rma_sale-sbj
branch
from
221cff1 to
7a0a726
Compare
sbejaoui
changed the title
victoralmau
suggested changes
May 18, 2026
| name="action_link_to_sale_order" | ||
| type="object" | ||
| string="Link to sale order" | ||
| attrs="{'invisible': [('move_id', '!=', False)]}" |
Member
There was a problem hiding this comment.
Suggested change
| attrs="{'invisible': [('move_id', '!=', False)]}" | |
| attrs="{'invisible': ['|', ('id', '=', False),('order_id', '!=', False)]}" |
|
|
||
| rma_id = fields.Many2one(comodel_name="rma") | ||
| partner_id = fields.Many2one(related="rma_id.partner_id") | ||
| sale_order_id = fields.Many2one( |
Member
There was a problem hiding this comment.
In my opinion, the best approach would be to select sales order lines (by filtering by product) and, within the action_link_rma_to_sale_order() method, also define the appropriate move_id to ensure that all data is consistent.
| <field name="arch" type="xml"> | ||
| <header position="inside"> | ||
| <button | ||
| name="action_link_to_sale_order" |
Member
There was a problem hiding this comment.
Suggested change
| name="action_link_to_sale_order" | |
| name="action_link_to_sale_order" | |
| groups="sales_team.group_sale_salesman" |
| <!-- Copyright 2026 ACSONE SA/NV | ||
| License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). --> | ||
| <odoo> | ||
|
|
Comment on lines
+27
to
+29
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, RMAs need to be created before the related sale order is known. This commit allows manually linking the RMA to a sale order afterward to improve traceability