Skip to content

[14.0][FW] queue_job: use queue_job row lock instead of queue_job_lock table - #993

Open
florentx wants to merge 5 commits into
OCA:14.0from
camptocamp:14.0-queue_job-lock
Open

[14.0][FW] queue_job: use queue_job row lock instead of queue_job_lock table#993
florentx wants to merge 5 commits into
OCA:14.0from
camptocamp:14.0-queue_job-lock

Conversation

@florentx

@florentx florentx commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@oca-cla-bot

oca-cla-bot Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@OCA-git-bot

OCA-git-bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:queue_job Module queue_job mod:test_queue_job Module test_queue_job series:14.0 mod:test_base_import_async Module test_base_import_async labels Sep 23, 2026
@florentx florentx changed the title [14.0] [FW] queue_job: use advisory lock instead of queue_job_lock table [14.0][FW] queue_job: use advisory lock instead of queue_job_lock table Sep 23, 2026
@florentx
florentx force-pushed the 14.0-queue_job-lock branch 2 times, most recently from 701f7c8 to 9ef1efe Compare September 23, 2026 09:44
UsmanGhias

This comment was marked as spam.

Sign in to view

@florentx florentx changed the title [14.0][FW] queue_job: use advisory lock instead of queue_job_lock table [14.0][FW] queue_job: use queue_job row lock instead of queue_job_lock table Sep 24, 2026
@florentx
florentx force-pushed the 14.0-queue_job-lock branch 3 times, most recently from 755f67a to 4e3409b Compare October 20, 2026 17:02
@florentx florentx mentioned this pull request Oct 26, 2026
Merged
@florentx
florentx force-pushed the 14.0-queue_job-lock branch from 4e3409b to bfd62a3 Compare October 26, 2026 19:59
@OCA-git-bot OCA-git-bot removed the mod:test_base_import_async Module test_base_import_async label Oct 26, 2026
@florentx
florentx force-pushed the 14.0-queue_job-lock branch from bfd62a3 to 8bdf619 Compare October 26, 2026 20:06
florentx and others added 4 commits October 26, 2026 21:13
@florentx
[FIX] queue_job: typo
a8f8ac6
@florentx
[FIX] queue_job: remove redundant closing() wrapper
7544344
@ivantodorovich @florentx
[FIX] queue_job: deadlock when the on fail hook writes the job's records
b1929b2 
The failure is handled from a temporary cursor while the failed job's
transaction still holds its locks: an on fail hook writing on the same
records waited forever. Perform the job in a savepoint so that its
locks are released when it fails.
@florentx
[IMP] queue_job: do not use separate cursor to write error result
ac68661
@florentx
florentx force-pushed the 14.0-queue_job-lock branch from 8bdf619 to d383d96 Compare October 26, 2026 20:13
@sbidoul

sbidoul commented Nov 2, 2026

Copy link
Copy Markdown
Member

Please keep in mind there is still an open question in #991 (comment)

@OCA-git-bot

OCA-git-bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@florentx
florentx force-pushed the 14.0-queue_job-lock branch from d383d96 to eb30302 Compare November 3, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@UsmanGhias UsmanGhias UsmanGhias left review comments
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@henrybackman henrybackman henrybackman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:queue_job Module queue_job mod:test_queue_job Module test_queue_job ready to merge series:14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@florentx @OCA-git-bot @sbidoul @ivantodorovich @henrybackman @UsmanGhias