Skip to content

[19.0] [MIG] queue_job_subscribe: migrate - #845

Merged
OCA-git-bot merged 4 commits into
OCA:19.0from
tishmen:pr6/queue_job_subscribe
Oct 26, 2026
Merged

[19.0] [MIG] queue_job_subscribe: migrate#845
OCA-git-bot merged 4 commits into
OCA:19.0from
tishmen:pr6/queue_job_subscribe

Conversation

@tishmen

@tishmen tishmen commented Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Scope

  • queue_job_subscribe

Depends on

Summary

  • Migrate to Odoo 19; tests included. No functional changes beyond compatibility.

Temporary references

  • test-requirements.txt adds temporary dependencies to the base PR for CI/runboat.
    This will be removed once the base PR merges.

Pre-commit

  • Ran locally; auto-fixes committed.

Tests

  • CI will run the suite using the referenced base PR.

@tishmen tishmen changed the title [19.0] queue_job_subscribe: migrate + tests [19.0] [MIG] queue_job_subscribe: migrate Oct 1, 2025
@tishmen tishmen mentioned this pull request Oct 1, 2025
Closed
4 tasks done
CasVissers-360ERP
CasVissers-360ERP approved these changes Nov 21, 2025
View reviewed changes

@CasVissers-360ERP CasVissers-360ERP left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@sbidoul sbidoul added this to the 19.0 milestone Jan 2, 2026
@tishmen tishmen mentioned this pull request Jan 5, 2026
Merged
Milan Topuzov and others added 4 commits January 9, 2026 18:43
Milan Topuzov @tishmen
[DON'T MERGE] test-requirements.txt (temp refs to base PR 840)
d55fa03 
- Use temporary references so CI/runboat picks queue_job from PR 840\n- Remove after base PR merges
Milan Topuzov @tishmen
[pre-commit] update excluded addons (queue_job_subscribe now included)
f673d48
Milan Topuzov @tishmen
pre-commit: autofixes (drop requirements.txt)
b85bacd
@tishmen
[FIX] queue_job_subscribe: drop temp test deps
5243fcb 
- Restore requirements.txt\n- Remove temporary git URL test requirements
@tishmen
tishmen force-pushed the pr6/queue_job_subscribe branch from bbc8ef3 to 5243fcb Compare January 9, 2026 17:45
@tishmen

tishmen commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

Hi @sbidoul @CasVissers-360ERP , I rebased this PR on the latest 19.0, removed the temporary test-requirements.txt git URL refs, and restored requirements.txt. CI is green now. Ready for review/merge.

dannyadair
dannyadair approved these changes Mar 5, 2026
View reviewed changes

@dannyadair dannyadair left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Reyes4711-S73
Reyes4711-S73 approved these changes Mar 17, 2026
View reviewed changes

@Reyes4711-S73 Reyes4711-S73 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-herholz-dt

john-herholz-dt commented Jun 23, 2026

Copy link
Copy Markdown

Can someone merge it?

@alan196 alan196 mentioned this pull request Jul 30, 2026
Open
@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 25, 2026
@Reyes4711-S73

Reyes4711-S73 commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

@guewen as a mantainer, please, can you review/merge this PR?

@guewen

guewen commented Oct 26, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-845-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit fced297 into OCA:19.0 Oct 26, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 383d9a0. Thanks a lot for contributing to OCA. ❤️

@guewen guewen mentioned this pull request Oct 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewen guewen guewen approved these changes
+3 more reviewers
@dannyadair dannyadair dannyadair approved these changes
@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes
@Reyes4711-S73 Reyes4711-S73 Reyes4711-S73 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

8 participants

@tishmen @OCA-git-bot @john-herholz-dt @Reyes4711-S73 @guewen @dannyadair @CasVissers-360ERP @sbidoul