[19.0][MIG] account_invoice_margin: Migration to 19.0#270
Open
Alexis-SDK wants to merge 59 commits into
Open
Conversation
OCA-git-bot
added
mod:account_invoice_margin
dannyadair
approved these changes
Jun 14, 2026
dannyadair
left a comment
dannyadair
left a comment
There was a problem hiding this comment.
LGTM
identical to #254 except not touching .pylintrc
Author
|
Hello @pedrobaeza , could you merge this PR, please? It supersedes the previous PR due to inactivity |
Member
|
It requires an approval from a PSC/maintainer: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review |
Member
|
/ocabot migration account_invoice_margin |
dreispt
approved these changes
Jun 15, 2026
dreispt
left a comment
dreispt
left a comment
Member
There was a problem hiding this comment.
Ideally the late fix commits should be squashed into one for a clean commit history.
Member
|
Yes, please the commit history is very messed right now. |
Author
|
Just to confirm, you’d like me to squash the last 6 fix commits into a single commit, correct? 
|
Member
|
Member
|
Rebase when I merge #271 |
Member
|
You can now rebase and do the squashing/commit renaming. |
[UPD] README.rst [UPD] Update account_invoice_margin.pot Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-11.0/margin-analysis-11.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-11-0/margin-analysis-11-0-account_invoice_margin/es/
[UPD] README.rst
…t invoice margin security group set
[FIX] account_invoice_margin: Set purchase_price when user has not set invoice margin security group set
[REF] rename file with the name of the model [ADD] margins on account.invoice model (and related views) [ADD] description and screenshot [FIX] Typo on margin (%) field name [ADD] fr translation
The invoice may be done in a currency different from the company currency, so the cost (purchase_price) amount will be incorrect in such context. TT38500
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/fr/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/fr_FR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/es/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-17.0/margin-analysis-17.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-17-0/margin-analysis-17-0-account_invoice_margin/it/
Alexis-SDK
force-pushed
the
19.0-mig-account-invoice-margin
branch
2 times, most recently
from
3d6eb0a to
e5d1854
Compare
Alexis-SDK
force-pushed
the
19.0-mig-account-invoice-margin
branch
from
e5d1854 to
1d872e7
Compare
Author
|
Is this okay for you? @dreispt |
Member
|
You have override the attribution of the work of the rest. I put before that expected squashing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new merge request as the previous one is not progressing, and waiting further would waste time
superseeded #254