[16.0][IMP]commission, account_commission: settlements grouped by payment date #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @pedrobaeza, |
matteonext
force-pushed
the
16.0-imp-commission
branch
4 times, most recently
from
b7da3bb to
f801d17
Compare
Contributor
Author
|
Hi @pedrobaeza, @etobella sorry for bother! |
matteonext
force-pushed
the
16.0-imp-commission
branch
2 times, most recently
from
49a3dbf to
3650074
Compare
matteonext
force-pushed
the
16.0-imp-commission
branch
2 times, most recently
from
6de78ca to
58aa857
Compare
matteonext
force-pushed
the
16.0-imp-commission
branch
3 times, most recently
from
19a7e9a to
56d6ba3
Compare
matteonext
force-pushed
the
16.0-imp-commission
branch
from
56d6ba3 to
91a9d45
Compare
Contributor
Author
|
Hi @pedrobaeza, @etobella sorry for bother! |
etobella
reviewed
Jan 31, 2026
Member
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
From my side, the code looks ok,
However, I don't know if it makes sense to split in an extra module and add the necessary hooks in account_comission 🤔
@pedrobaeza WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr allows to generate commissions based on the payment date.
For example, if you have three invoices from three different months but with a payment date in the same month, the current behavior generates three separate period, one for each month. With this change, however, all commissions are assigned to a single period.
It covers a similar scope but is managed in a different way #581