fix: unpack OpenWave's Changed signal as its four parts so pushes arrive - #1
Merged
Merged
Conversation
org.gtk.Actions.Changed is (as a{sb} a{sv} a{s(bgav)}); unpacking three
names raised ValueError, which the relay swallowed, so every push was
dropped and the deck only refreshed on its 1 s poll.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
owdeck/ipc.pyunpackedorg.gtk.Actions.Changedinto three names, but the signal is(as a{sb} a{sv} a{s(bgav)}): removed, enabled, state, added. TheValueErrorwas swallowed by the relay'sexcept, so every push from OpenWave was dropped, and the deck only updated on its 1 s refresh. This affects both the Python app and upstream's Rust rewrite, which keeps the same D-Bus contract.Fix
Unpack all four parts and keep the state map.
TestChangedSignalbuilds the real four-part variant with GLib and drives it through_attach's relay. It fails before the fix and passes after.Verification
python3 -m unittest discover -s tests -t .: 115 tests OK.Merging to main triggers semantic-release (a patch release).
🤖 Generated with Claude Code