Repository navigation
fix: data files never select zero tests; intent from the working session (0.23.1) - #59
Merged
Merged
Conversation
… full suite A changed .sql, .cypher, .graphql or other data file with graph nodes but no dependents selected zero tests: CGraph records no reads of data, so the graph's silence there is not evidence that nothing reads it. Its own walk reaching no test and nothing outside the file now fails open with an unmapped-file reason marked unreached; code files keep zero tests. On turing-api every migration edit selected 0 tests (5 of 5 tried). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ession that worked Entire attaches every session live in the checkout when a commit is made. Narration and test commands were taken from the first session with any text, so a PR's Intent opened with another task's narration (turing-webapp#827: a call-summary session among ten). When some session worked on the commit's files, only those now count, as the ask already did. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR brief: 4 agent commits · 16 of 25 test files reach this diffRun at least these. Selection is a safe superset; it never marks a test safe to skip.
What each commit did
Claims checked
What each changed file reaches
Paths above are under Tests to run (16)
Blast radius by changed file: 42 dependents
blastline 0.23.1. Selection is advisory unless your workflow gates on it. How selection works. Graph |
Review of #59: a migration that only another migration's foreign key points at (sql_table references sql_table) still selected zero tests, because its walk reached a file outside itself. Drop that condition: a data file whose walk reaches no test fails open, whatever it reached. Remove the advise() call that could never run (references are built for nodeless files only). Tests for data reached by data, data reached by untested code, and a manifest walked through its readers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
taylorg009
marked this pull request as ready for review
October 21, 2026 02:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two correctness bugs in what the brief tells reviewers:
.sql,.cypher,.graphqlor other data file with graph nodes but no dependents was seeded like code, and its walk reached nothing. CGraph extracts dependencies only from code, so for data the graph's silence is not evidence that nothing reads the file. On a TypeScript service, a one-line edit to each of five migrations selected 0 tests on 0.23.0. A recent PR there selected 226 of 330 tests, and its migration contributed none of them.What changes
select.ts: a mapped file that isn't code (isCodePathindetect.ts, matching CGraph's grammar languages) fails open when its own walk reaches no test and nothing outside the file. The reason isunmapped-filewithunreached: true, and the comment says the file "has graph nodes nothing points at".inert) are unaffected.checkpoint.ts: when any session worked on the commit's files, only those sessions supply the narration and test commands, as the prompt already did. The same-step check still counts every session's activity.Evidence
subset tests= 0for each, and this branch givesallwith theunreachedreason.checkpointForon its checkpoint, 10 sessions).select.test.ts,comment.test.tsandcheckpoint.test.tsfail without the fixes.🤖 Generated with Claude Code