Skip to content

diag: Windows persist retry timing (do not merge) - #211

Closed
taylorg009 wants to merge 3 commits into
mainfrom
diag-windows-persist
Closed

taylorg009 wants to merge 3 commits into
mainfrom
diag-windows-persist

Conversation

@taylorg009

Copy link
Copy Markdown
Collaborator

Throwaway diagnostic, do not merge. Runs only the Windows jobs and repeats cgraph_daemon_server_test up to 25 times, logging each graph.json persist attempt and each skip caused by a busy graph_mutex, to explain the windows-release flake "incremental state re-persisted to graph.json" (one failed rename, then no retry for 12 seconds). Will be closed once the logs are read.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR brief: 0 agent commits · 28 of 110 test files reach this diff

Run at least these. Selection is a safe superset; it never marks a test safe to skip.

Summary PR #211 at 865eab3
Changed 7 files: 6 mapped to 8 symbols, 1 ignored by policy
Tests reached 28 of 110 ▮▮▮▮▮▯▯▯▯▯▯▯▯▯▯▯▯▯▯▯ 25% of the suite
Downstream code 12 files, 123 dependents
Intent no checkpoints on this branch (3 commits)
Since push 719b366 1 new commit, 0 changed files, 0 tests reached
Compared against base d0cbc70

What each commit did

Commit Intent Files Reaches Ran before push
be8b5ca diag: time Windows persist retries in daemon_server_test (d… no checkpoint 3 files 1 file, 3 tests
719b366 diag: name graph.json holders via Restart Manager; non-thro… no checkpoint 5 files 12 files, 28 tests
865eab3 diag: share-delete test reader (do not merge) no checkpoint 1 file 0 files, 1 test

Claims checked

no checkpoint on this branch makes a claim the graph can check

What each changed file reaches

Changed file Symbols touched Reaches Tests
atomic_write.cpp diag_print_holders, replace_file 12 files 24
file_cache.cpp classify_cached_file 4 files 12
semantic_chunk_plan.cpp is_valid_cached_record 3 files 7
incremental_update.cpp apply_incremental_code_updates 1 file 6
daemon_server.cpp run_daemon_server 1 file 3
tests/smoke/daemon_server_test.cpp test code, selected directly 1
.github/workflows/ci.yml ignored by policy 0

Paths above are under src/engine/ unless shown in full.

Tests to run (28)

Blast radius by changed file: 123 dependents

blastline 0.13.0. Selection is advisory unless your workflow gates on it. How selection works. Graph 289f17b. Intent: 0 of 3 commits. Not checked: symbol changes: no --change-context given.

taylorg009 and others added 2 commits October 20, 2026 18:06
…s (do not merge)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@taylorg009

Copy link
Copy Markdown
Collaborator Author

Diagnostic done: it located the cause of the Windows flake (the test's own non-share-delete reader) and a daemon exit on 'exists: Access is denied'. Both are fixed in #212, which merged after this harness passed 40/40 on each Windows job.

@taylorg009 taylorg009 closed this Oct 21, 2026
@taylorg009
taylorg009 deleted the diag-windows-persist branch October 21, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant