Veratex: Sanitize decrypted mail body before rendering as HTML to prevent stored XSS - #6
Open
veratex-ai[bot] wants to merge 1 commit into
Open
Veratex: Sanitize decrypted mail body before rendering as HTML to prevent stored XSS#6veratex-ai[bot] wants to merge 1 commit into
veratex-ai[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Veratex prepared this fix but did not auto-merge because the agent flagged it for human review. mails.ts rendered decrypted mail bodies via innerHTML with no sanitization, letting any friend send HTML/script payloads that execute in the recipient's webview (stored XSS with local gRPC access); fixed by sanitizing with DOMPurify before assignment. Risks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2.
Summary
mails.ts rendered decrypted mail bodies via innerHTML with no sanitization, letting any friend send HTML/script payloads that execute in the recipient's webview (stored XSS with local gRPC access); fixed by sanitizing with DOMPurify before assignment.
Verification
Results above were observed by Veratex re-running each suite in its sandbox; the agent's own report is never used for a merge decision.
Risks to review
Opened automatically by Veratex (runner: e2b). This branch was produced by an AI agent from the linked issue.