MOOSE target: reject dim != 3 tensors; emit layout static_asserts (#7, #10) - #154
Open
petlenz wants to merge 2 commits into
Open
MOOSE target: reject dim != 3 tensors; emit layout static_asserts (#7, #10)#154petlenz wants to merge 2 commits into
petlenz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7. Closes #10.
#7 — dim guard: MOOSE's RankTwoTensor/RankFourTensor are always 3D (LIBMESH_DIM = 3); a dim-2 recipe previously emitted tmech::adaptor reads with dim-2 strides over 3x3 storage — a silent quadrature-point miscompute, not a compile error.
emit()now rejects any dim != 3 tensor input/output with a message that names the symbol and points at the dim-3 embedding convention for plane-strain/axisymmetric models.#10 — layout static_asserts: the contiguous-row-major-Real storage assumption behind the adaptor boundary was prose in a header comment. The generated
.Cnow carriesstatic_assert(sizeof(RankTwoTensor) == 9 * sizeof(Real))and the rank-4 sibling, so a MOOSE-internal layout change becomes a compile error in the consumer's build instead of silently wrong stress.Tests:
MooseTarget.RejectsNonThreeDimensionalTensors,MooseTarget.SourceEmitsLayoutStaticAsserts. Full Debug (-Werror) ctest green (known local sibling-drift failure aside, see #140).Note for the in-flight MOOSE-stub compile gate (#132): the stub's tensor types must satisfy the sizeof asserts (plain
Real[9]/Real[81]storage does).