Preserve Java source path fidelity in compile smoke script#12
Merged
Nullkernel merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
javacreports filename/path-related errors reliably instead of masking them by renaming files to detected public class names.Description
scripts/compile_smoke.shto copy each Java source into the temp workspace using a mirrored relative path at"$work_dir/$file"instead of renaming files to the public class name.mkdir -p "$(dirname "$compile_target")"so the source tree is mirrored under the temp work dir.find ... | LC_ALL=C sort) and preserved the per-file[PASS]/[FAIL]reporting and aggregated failure counting.Testing
bash scripts/compile_smoke.shand confirmed per-file[PASS]/[FAIL]output appears and the script exits non-zero when compiler errors are present (observed expected failures where public class names did not match file names).Codex Task