Skip to content

Preserve Java source path fidelity in compile smoke script#12

Merged
Nullkernel merged 1 commit intomainfrom
codex/update-compile_smoke.sh-for-path-fidelity
Apr 5, 2026
Merged

Preserve Java source path fidelity in compile smoke script#12
Nullkernel merged 1 commit intomainfrom
codex/update-compile_smoke.sh-for-path-fidelity

Conversation

@Nullkernel
Copy link
Copy Markdown
Owner

Motivation

  • Make the smoke compile step reflect real source filenames and relative paths so javac reports filename/path-related errors reliably instead of masking them by renaming files to detected public class names.

Description

  • Updated scripts/compile_smoke.sh to copy each Java source into the temp workspace using a mirrored relative path at "$work_dir/$file" instead of renaming files to the public class name.
  • Ensure parent directories are created before copying with mkdir -p "$(dirname "$compile_target")" so the source tree is mirrored under the temp work dir.
  • Kept deterministic file ordering (find ... | LC_ALL=C sort) and preserved the per-file [PASS]/[FAIL] reporting and aggregated failure counting.

Testing

  • Ran bash scripts/compile_smoke.sh and confirmed per-file [PASS]/[FAIL] output appears and the script exits non-zero when compiler errors are present (observed expected failures where public class names did not match file names).
  • No other automated tests were changed.

Codex Task

@Nullkernel Nullkernel merged commit dcff640 into main Apr 5, 2026
1 check failed
@Nullkernel Nullkernel deleted the codex/update-compile_smoke.sh-for-path-fidelity branch April 6, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant