Skip to content

Simplify Docker setup#992

Merged
plural merged 1 commit intomainfrom
chore/update-docker-setup
Mar 26, 2026
Merged

Simplify Docker setup#992
plural merged 1 commit intomainfrom
chore/update-docker-setup

Conversation

@alsciende
Copy link
Copy Markdown
Collaborator

Hello folks. I wanted to set up a local nrdb and found your cool Docker files. A few things in the docker-compose.yaml file surprised me and I tried to understand it. I think I found a simpler setup, let me know what you think. It works for me.

  • removed the named volumes on /vendor and /var which are in .gitignore anyway
  • removed the named volumes on /bin and /web because there's no reason they would be changed unexpectedly. The data in /web is already ignored by .gitignore.
  • removed the named volumes on /app/config because I created a mount volume on /app/config/parameters.yml instead of copying files around

Consequently, I simplified docker/docker-first-run.sh too because no files need to be copied.

Benefits of this MR:

  • Faster setup
  • Easier to understand and maintain
  • The vendors installed by "composer install" in vendor/ are accessible outside the container, so available to the IDE
  • The logs files in var/log/ are accessible outside the container, should you need them

Copy link
Copy Markdown
Collaborator

@plural plural left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks! We set up the initial docker stuff a long time ago and the two of us that did it were fairly new to docker so it was ... messy!

@plural plural merged commit 77ad404 into main Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants