Conversation
plural
approved these changes
Mar 26, 2026
Collaborator
plural
left a comment
There was a problem hiding this comment.
looks great, thanks! We set up the initial docker stuff a long time ago and the two of us that did it were fairly new to docker so it was ... messy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello folks. I wanted to set up a local nrdb and found your cool Docker files. A few things in the docker-compose.yaml file surprised me and I tried to understand it. I think I found a simpler setup, let me know what you think. It works for me.
Consequently, I simplified
docker/docker-first-run.shtoo because no files need to be copied.Benefits of this MR: