Fix #20 (% on High Skill avg-pick) + add a build CI workflow#23
Open
bloppbot wants to merge 2 commits into
Open
Fix #20 (% on High Skill avg-pick) + add a build CI workflow#23bloppbot wants to merge 2 commits into
bloppbot wants to merge 2 commits into
Conversation
GradientCell defaults suffix to '%', which is correct for win-rate columns but wrong for avg-pick (which is a 1-40 position number). Other pages like Abilities.tsx already pass suffix="" explicitly on their pick-position columns; doing the same here.
Repo currently has no CI; this runs npm ci + tsc + vite build on push to main and on every PR, so build regressions surface before deploy. Lint is intentionally not wired up here since there are existing lint errors in main; that can be a separate cleanup PR.
✅ Deploy Preview for windrun ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Noxville — long-time reader of windrun.io, thought I'd send a small contribution. The site is a great resource for AD players. Two unrelated but small changes bundled here so you only have to review once; happy to split if you'd prefer.
1. Fix #20:
%on High Skill avg-pick columnsThe
GradientCellcomponent defaultssuffix='%', which is correct for the win-rate columns but renders avg-pick (a 1–40 position number) as e.g.12.3%. This is exactly what the screenshot in #20 shows.Abilities.tsxalready handles this correctly by passingsuffix=""explicitly on its pick-position columns. I followed the same pattern inAbilityHighSkill.tsxforavgPickHighSkillandavgPickAll.I considered changing the
GradientCelldefault to''instead, but that has more blast radius — every page usingGradientCellfor win-rates would need an explicitsuffix="%". Left the default alone, only fixed the two call sites that were rendering wrong.Files changed:
src/pages/AbilityHighSkill.tsx(+2 lines)2. Add a build workflow
There are no GitHub Actions workflows in the repo yet, so PRs (including this one) can't get a green check. I added
.github/workflows/build.ymlthat runsnpm ci && npm run buildon push tomainand on every PR.This catches TypeScript or Vite build regressions before deploy, which seemed worth it given the manual
scpdeploy mentioned in the README.A couple of conscious choices:
npm run lintleft out on purpose. Running it onmainright now produces 32 errors (mostly@typescript-eslint/no-explicit-anyandreact-hooks/static-components), so turning it on as a CI gate without first cleaning them up would block every future PR. Happy to do a separate lint-cleanup PR if you'd like, or you can wire lint in later when convenient.Files changed:
.github/workflows/build.yml(new file, 24 lines)Verifying
npm ci && npm run buildlocally — clean build, no new warnings.%).Happy to revise either of these — or split into two PRs if you'd prefer to merge them independently. Thanks for windrun.io!