fix: traverse alias_pointer in getPageContentBlockIds#698
Open
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Open
fix: traverse alias_pointer in getPageContentBlockIds#698albertodainotti wants to merge 1 commit intoNotionX:masterfrom
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Conversation
Add alias_pointer traversal alongside existing transclusion_reference_pointer traversal, ensuring pages referenced via alias blocks are included in the set of block IDs fetched by fetchMissingBlocks.
|
@albertodainotti is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getPageContentBlockIdstraversestransclusion_reference_pointerto resolve referenced blocks, but it does not traversealias_pointer. When a Notion page contains alias (synced) blocks, their content is not included in the page content block IDs, causing those blocks to not render.Fix
Added traversal of
format.alias_pointer.idalongside the existingtransclusion_reference_pointertraversal. When an alias pointer is found, we calladdContentBlocks(aliasId)to recursively include the aliased block's content.Files Changed
packages/notion-utils/src/get-page-content-block-ids.ts— Added 5 lines to handlealias_pointer