fix: prevent page icons from being squashed in table cells#692
Open
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Open
fix: prevent page icons from being squashed in table cells#692albertodainotti wants to merge 1 commit intoNotionX:masterfrom
albertodainotti wants to merge 1 commit intoNotionX:masterfrom
Conversation
Add flex-shrink: 0 to .notion-page-icon-inline inside table cells to prevent long title text from compressing the icon.
|
@albertodainotti is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a table cell title is very long, the flexbox layout compresses the inline page icon to a smaller size. This happens because
.notion-page-icon-inlinehas noflex-shrinkconstraint, so the browser shrinks it to make room for the text.Fix
Prevents the icon from being compressed regardless of title length.
Files Changed
packages/react-notion-x/src/styles.css(+4 lines)