Conversation
EmailTemplate.Text was accepted and persisted by the API but never reached a send: CompileTemplateResponse had no Text field, SendEmailProviderRequest had a single HTML-only Content field, and none of the seven provider integrations (SES, SMTP, SendGrid, Postmark, Mailgun, Mailjet, SparkPost) ever built a multipart/alternative message. Every outbound email - broadcast, automation, transactional - went out text/html only regardless of what a template's text field held. SendEmailForTemplate now renders the plain-text alternative through the same Liquid variables as the subject (a rendering failure falls back to the raw text instead of failing the send) and passes it through SendEmailProviderRequest.PlainText. Each provider builds a proper multipart/alternative body when it is set; templates with no plain text are unaffected and keep sending HTML-only exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #426. EmailTemplate.Text was accepted and persisted by the API but never reached a send: CompileTemplateResponse had no Text field, SendEmailProviderRequest had a single HTML-only Content field, and none of the seven provider integrations (SES, SMTP, SendGrid, Postmark, Mailgun, Mailjet, SparkPost) ever built a multipart/alternative message. Every outbound email - broadcast, automation, transactional - went out text/html only regardless of what a template's text field held.