Repository navigation
fix(search): find a model number typed after the brand or name - #167
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
UI
Overview
Searching a model number on its own worked, but put the brand in front ("samsung SM-G973F", "oneplus a6003") and nothing came back. The number gets split into letters and digits, so none of the bits matched by themselves. Now a run of words that joins up into a phone's model number (or the end of one, like
G991BforSM-G991B) counts as a match, and outranks a near-miss on the name.Additional Info
Ran every model number we have with its brand in front, before and after: 1527 found nothing before, 5 do now. 1630 of 1637 land on their own phone first, and the other 7 are numbers that two pages share. Normal name searches come out the same.