[hardening] TBL load integer overflow + memory-safety cleanups#3
Draft
Not4right wants to merge 1 commit into
Draft
[hardening] TBL load integer overflow + memory-safety cleanups#3Not4right wants to merge 1 commit into
Not4right wants to merge 1 commit into
Conversation
See PR description for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening patch set covering one critical finding (TBL load integer
overflow → out-of-bounds write on 32-bit flight targets) plus several
medium-severity defensive cleanups.
See the accompanying GitHub issue for the full writeup of the critical
finding and a conceptual reproducer.
Summary of changes
cfe_tbl_passthru_codec.cOffset+NumBytesagainst unsigned overflow before size check.cfe_tbl_eds_codec.ccfe_tbl_load.csize_tarithmetic.cfe_tbl_internal.cmemchr+strcpyinMarkNameAsModified; add bounds and small-buffer guards.cfe_es_mempool.cOS_MutSemTake/OS_MutSemGivefailures (matches SB/FS/CDS convention).cfe_es_cds.c,cfe_sb_priv.csprintf→snprintf(MISRA-C compliance and config-widening robustness).osal/src/os/vxworks/src/os-impl-tasks.clrec->heap_blockimmediately afterfreeso dangling state is never observable.Pre-merge checklist
cfe/modules/tbl/ut-coverage/for the wrap-around case (Offset = 0xFFFFFFF0,NumBytes = 0x100).size_tis 32 bits.