LLT-7052: DNS packet codec#1688
Merged
tomasz-grz merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
tomasz-grz
force-pushed
the
packet_codec
branch
from
8bc69ea to
50ec209
Compare
tomasz-grz
force-pushed
the
packet_codec
branch
from
50ec209 to
b87a3d4
Compare
tomasz-grz
force-pushed
the
packet_codec
branch
from
b87a3d4 to
9bbe892
Compare
tomasz-grz
commented
Feb 24, 2026
tomasz-grz
force-pushed
the
packet_codec
branch
from
9bbe892 to
87a56cb
Compare
tomasz-grz
force-pushed
the
packet_codec
branch
from
87a56cb to
1f03629
Compare
stalowyjez
reviewed
Feb 26, 2026
Contributor
stalowyjez
left a comment
stalowyjez
left a comment
There was a problem hiding this comment.
I have mixed feeling for this PR, reducing dependencies is always nice, but it feels a bit like reinventing the wheel. We also have some code in libfirewall which does some DNS parsing, maybe we should create some public DNS helper crate for pnet which would address our needs?
stalowyjez
reviewed
Feb 27, 2026
stalowyjez
reviewed
Mar 3, 2026
Contributor
stalowyjez
left a comment
stalowyjez
left a comment
There was a problem hiding this comment.
Looks good enough, +1
Contributor
I have the same feeling, and I'm also missing explanation why we want to "get rid of all hickory_server dependencies." |
Contributor
And what if they are not? |
tomaszklak
reviewed
Mar 17, 2026
Contributor
|
Please, remember to cleanup (squash?) commits. |
tomasz-grz
force-pushed
the
packet_codec
branch
from
408a415 to
327fb7f
Compare
Contributor
|
+1 |
tomasz-grz
force-pushed
the
packet_codec
branch
from
327fb7f to
8c89718
Compare
Contributor
|
Next time: It would be really nice to include ticket number in the branch name 🙏 🙏 🙏 |
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
Jauler
reviewed
Mar 18, 2026
tomasz-grz
force-pushed
the
packet_codec
branch
from
20db861 to
e68879a
Compare
mathiaspeters
approved these changes
Mar 23, 2026
tomasz-grz
force-pushed
the
packet_codec
branch
from
e68879a to
b6c2f87
Compare
This module incorporates: - a lightweight decoder, that converts DNS request bytes into a `DnsPacket<'_>`, and exposes a helper functions like `parse_dns_query_packet()`, `find_nord_query()` and `normalize_qname()` to simplify with the correct request handling. - A packet builder specific for the local resolver use case, that converts a `ResponseKind` enum into appropriate DNS response bytes.
tomasz-grz
force-pushed
the
packet_codec
branch
from
b6c2f87 to
009dbae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We want to get rid of all
hickory_serverdependencies, because it set's up a full blown DNS server, we maintain our own (outdated) fork of, and it was source of a lot of bugs.As a first step we need to decide if DNS requests are related to
.nordzone.If they are, they should handled by our local resolver, and we need to serve the response packet back.
If not, the request is forwarded and resolved by the upstream nameservers.
Solution
This module incorporates:
DnsPacket<'_>struct, and exposes a helper functions likeparse_dns_packet(),find_nord_query()andnormalize_qname()to simplify with the correct request handling.ResponseKindenum into appropriate DNS response bytes.☑️ Definition of Done checklist