Repository navigation
Light theme and export panel polish - #7
Merged
Merged
Conversation
… in, keep focused fields readable, and rework the light theme
… a limit, and drop copy clip times from the menus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A polish pass on the preview audio picker, the export panel, the timeline zoom buttons and the light theme.
soloClickoption onDropdownSelect, so the export panel's pickers keep the old toggle behaviour.AdvancedSectioncomponent. The options are always rendered and visible. Only the box around them animates its height from 0 toauto(interpolate-size), so unfolding uncovers options that are already drawn instead of fading them in. The box clips only while it moves, so the Other tracks dropdown can still spill out once it's open. It isinertonly once fully folded, to keep hidden options out of the tab order. While Advanced opens, the modal body scrolls along, so the options don't unfold below the fold.minimumViewLength, instead of three copies.:where(), so the shortcut search can still skip the ring when it takes focus as the tab opens.Verification
bun run formatandbun run verify: 446 unit tests pass, including a newcanZoomtest that steps from fit to both limits.inertwhile Advanced opens and folds. Options are visible on every frame, clipping lifts once it settles, and folded means 0px andinert.scene-cutssends the copy commands overapp:command.export-dialogchecks the folded box instead oftoBeHidden.export-workflowbuilds a track mix with Shift-clicks, which keeps it covering the remuxed preview.control-conventionsgains a switch-drag test.export-workflowandsettings-reset, both fixed here.For review
bun run release.