Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
//! A big-endian PowerPC64 ELF whose `e_flags` declare ABI version 2 (ELFv2,
//! e.g. musl or `-mabi=elfv2`) takes the `elfv2` compiler spec: its frame
//! header is 32 bytes, not ELFv1's 48, so stack parameters start at SP+96.
//! Little-endian PowerPC64 is ELFv2 throughout and its default spec says so.
use object::{Architecture, FileFlags, Object};

const ID: &str = "PowerPC:BE:64:default:elfv2";

pub(crate) fn language_ids() -> impl Iterator<Item = String> {
std::iter::once(ID.to_string())
}

pub(crate) fn language_id(file: &object::File<'_>) -> Option<String> {
(file.format() == object::BinaryFormat::Elf
&& file.architecture() == Architecture::PowerPc64
&& !file.is_little_endian()
&& matches!(file.flags(), FileFlags::Elf { e_flags, .. } if e_flags & 3 == 2))
.then(|| ID.to_string())
}

#[cfg(test)]
mod tests {
use object::write::Object;
use object::{Architecture, BinaryFormat, Endianness, FileFlags};

fn selected(endian: Endianness, e_flags: u32) -> Option<String> {
let mut object = Object::new(BinaryFormat::Elf, Architecture::PowerPc64, endian);
object.flags = FileFlags::Elf { os_abi: 0, abi_version: 0, e_flags };
let bytes = object.write().unwrap();
super::language_id(&object::File::parse(&*bytes).unwrap())
}

#[test]
fn only_a_big_endian_abi_version_2_image_takes_the_elfv2_spec() {
assert_eq!(selected(Endianness::Big, 2).as_deref(), Some(super::ID));
assert_eq!(selected(Endianness::Big, 1), None, "ELFv1");
assert_eq!(selected(Endianness::Big, 0), None, "unspecified stays ELFv1");
assert_eq!(selected(Endianness::Little, 2), None, "LE's default spec is ELFv2");
}
}
1 change: 1 addition & 0 deletions decompiler/crates/kuna-analysis/src/loader/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

pub mod arm_markers;
pub(crate) mod kuna_ppcaputarget;
pub(crate) mod kuna_ppc64elfv2target;
#[cfg(test)]
mod powerpc_apu_tests;
pub(crate) mod kuna_mipstarget;
Expand Down
4 changes: 4 additions & 0 deletions decompiler/crates/kuna-analysis/src/loadimage_object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1856,6 +1856,9 @@ fn language_id_for(
if let Some(id) = crate::loader::kuna_ppcaputarget::language_id(file) {
return Ok(id.into_bytes());
}
if let Some(id) = crate::loader::kuna_ppc64elfv2target::language_id(file) {
return Ok(id.into_bytes());
}
if let Some(id) = crate::loader::kuna_mipstarget::language_id(file)? {
return Ok(id.into_bytes());
}
Expand Down Expand Up @@ -2163,6 +2166,7 @@ pub fn elf_language_ids() -> Vec<String> {
}
}
out.extend(crate::loader::kuna_ppcaputarget::language_ids());
out.extend(crate::loader::kuna_ppc64elfv2target::language_ids());
out.extend(crate::loader::kuna_mipstarget::language_ids());
out.extend(crate::loader::kuna_mipsocteon::language_ids());
out.sort();
Expand Down
3 changes: 2 additions & 1 deletion decompiler/crates/kuna-base/src/xml.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2205,7 +2205,8 @@ mod tests {
// and kuna-repframecopy / a by-value argument copied with rep movs reaches its call
// and kuna-libcnames-win32 / a local takes the name of the Win32 call it meets
// and kuna-libcnames-addr / a stack object takes the name of the library parameter its address meets
assert_eq!(count, 756, "corpus file count drifted");
// and kuna-ppc64le-elfv2-stack-args / an ELFv2 stack argument follows the 32-byte header
assert_eq!(count, 758, "corpus file count drifted");
}

/// ~20 representative SLEIGH spec files across varied processors
Expand Down
4 changes: 3 additions & 1 deletion decompiler/crates/kuna-cli/tests/powerpc_isa_selection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,11 @@ fn generic_powerpc_failure_explains_the_explicit_isa_override() {
&bytes,
)
.unwrap();
// A big-endian image that declares ELFv2 takes the ELFv2 compiler spec.
let compiler = if name == "BE" && abi == 2 { "elfv2" } else { "default" };
assert_eq!(
loader.get_arch_type(),
format!("{generic}:default").as_bytes()
format!("{generic}:{compiler}").as_bytes()
);
std::fs::write(&path, bytes).unwrap();
for options in [vec![], vec!["--target", generic.as_str()], vec!["--json"]] {
Expand Down
8 changes: 6 additions & 2 deletions docs/baseline-stages.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"data_footer": [
4340,
4340
4344,
4344
],
"passing": [
"data:64-bit logical shift retains unsigned destination",
Expand Down Expand Up @@ -3701,6 +3701,10 @@
"data:pointer-arguments #2: no declaration leaks between standalone renders",
"data:positive displacement stays symbolic",
"data:post(y) runs once per pass",
"data:ppc64be-elfv2-stack-args #1: the callee reads its ninth argument",
"data:ppc64be-elfv2-stack-args #2: the caller passes n + 9 as the ninth",
"data:ppc64le-elfv2-stack-args #1: the callee reads its ninth argument",
"data:ppc64le-elfv2-stack-args #2: the caller passes n + 9 as the ninth",
"data:preloaded SPARC stack read: capture stays before branch",
"data:preloaded SPARC stack read: guarded consumer retains saved value",
"data:preloaded SPARC stack read: volatile slot retained",
Expand Down
1 change: 1 addition & 0 deletions specs/Ghidra/Processors/PowerPC/data/languages/ppc.ldefs
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<description>PowerPC 64-bit big endian w/Altivec, G2</description>
<compiler name="default" spec="ppc_64_be.cspec" id="default"/>
<compiler name="Mac OS X" spec="ppc_64_be_Mac.cspec" id="macosx"/>
<compiler name="ELFv2" spec="ppc_64_be_elfv2.cspec" id="elfv2"/>
<external_name tool="gnu" name="powerpc:common64"/>
<external_name tool="IDA-PRO" name="ppc"/>
<external_name tool="DWARF.register.mapping.file" name="ppc.dwarf"/>
Expand Down
206 changes: 206 additions & 0 deletions specs/Ghidra/Processors/PowerPC/data/languages/ppc_64_be_elfv2.cspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- This cspec is based upon the PowerPC 64-bit ELF ABI specification -->
<!-- Very similar to the PowerPC 64-bit little-endian cspec, but reverses justification when
assigning odd datatype sizes -->
<compiler_spec>
<data_organization>
<machine_alignment value="8" />
<default_alignment value="1" />
<default_pointer_alignment value="8" />
<pointer_size value="8" />
<wchar_size value="4" />
<short_size value="2" />
<integer_size value="4" />
<long_size value="8" />
<long_long_size value="8" />
<float_size value="4" />
<double_size value="8" />
<long_double_size value="16" />
<size_alignment_map>
<entry size="1" alignment="1" />
<entry size="2" alignment="2" />
<entry size="4" alignment="4" />
<entry size="8" alignment="8" />
<entry size="16" alignment="16" />
</size_alignment_map>
</data_organization>
<global>
<range space="ram"/>
</global>
<stackpointer register="r1" space="ram"/>
<default_proto>
<prototype name="__stdcall" extrapop="0" stackshift="0">
<input>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f1"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f2"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f3"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f4"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f5"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f6"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f7"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f8"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f9"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f10"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f11"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f12"/>
</pentry>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f13"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r3"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r4"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r5"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r6"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r7"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r8"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r9"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r10"/>
</pentry>
<!-- ELFv2: the parameter save area follows the 32-byte frame header
(back chain, CR, LR, TOC), so the ninth doubleword is at SP+96. -->
<pentry minsize="1" maxsize="500" align="8">
<addr offset="96" space="stack"/>
</pentry>
<rule>
<datatype name="homogeneous-float-aggregate" maxprimitives="1"/>
<join storage="float"/>
<extra_stack afterstorage="general" afterbytes="64"/>
<consume_extra storage="general"/>
</rule>
<rule>
<datatype name="float"/>
<join storage="float"/> <!-- The join is NOT aligned -->
<extra_stack afterstorage="general" afterbytes="64"/>
<consume_extra storage="general"/>
</rule>
<!-- Values are packed big-endian within registers, but packing registers and stack dwords
together is done in the little-endian fashion -->
<rule>
<datatype name="struct" minsize="8"/>
<join align="true" reversejustify="true"/>
</rule>
<rule>
<datatype name="union" minsize="8"/>
<join align="true" reversejustify="true"/>
</rule>
<rule>
<datatype name="any"/>
<join align="true"/> <!-- The join IS aligned -->
</rule>
</input>
<output>
<pentry minsize="1" maxsize="8" metatype="float" extension="float">
<register name="f1"/>
</pentry>
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r3"/>
</pentry>
<rule>
<datatype name="struct"/>
<convert_to_ptr/>
</rule>
<rule>
<datatype name="union"/>
<convert_to_ptr/>
</rule>
</output>
<unaffected>
<register name="r14"/>
<register name="r15"/>
<register name="r16"/>
<register name="r17"/>
<register name="r18"/>
<register name="r19"/>
<register name="r20"/>
<register name="r21"/>
<register name="r22"/>
<register name="r23"/>
<register name="r24"/>
<register name="r25"/>
<register name="r26"/>
<register name="r27"/>
<register name="r28"/>
<register name="r29"/>
<register name="r30"/>
<register name="r31"/>
<register name="r1"/>
<!-- In cases where r2 does change, we assume it will get restored -->
<register name="r2"/>
<register name="r2Save"/>
<register name="f14"/>
<register name="f15"/>
<register name="f16"/>
<register name="f17"/>
<register name="f18"/>
<register name="f19"/>
<register name="f20"/>
<register name="f21"/>
<register name="f22"/>
<register name="f23"/>
<register name="f24"/>
<register name="f25"/>
<register name="f26"/>
<register name="f27"/>
<register name="f28"/>
<register name="f29"/>
<register name="f30"/>
<register name="f31"/>
<register name="cr2"/>
<register name="cr3"/>
<register name="cr4"/>
</unaffected>
<killedbycall>
<register name="r3"/>
<register name="f1"/>
</killedbycall>
<pcode inject="uponreturn">
<body>
# Inject pcode when returning from a function call to place the r2Save
# value into 0x18(r1) which should be restored by the "ld r2,0x18(r1)"
# which immediately follows calls which comply with the PPC64 ELFv2 ABI
# (ELFv1 saves the TOC at 0x28).
local saveR2ptr = r1 + 0x18;
*:8 saveR2ptr = r2Save;
</body>
</pcode>
</prototype>
</default_proto>
</compiler_spec>
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@
<pentry minsize="1" maxsize="8" extension="inttype">
<register name="r10"/>
</pentry>
<!-- ELFv2: the parameter save area follows the 32-byte header
(back chain, CR, LR, TOC), so the ninth doubleword is at 96. -->
<pentry minsize="1" maxsize="500" align="8">
<addr offset="112" space="stack"/>
<addr offset="96" space="stack"/>
</pentry>
<rule>
<datatype name="homogeneous-float-aggregate" maxprimitives="1"/>
Expand Down
41 changes: 41 additions & 0 deletions tests/stages/kuna-ppc64be-elfv2-stack-args.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<decompilertest>
<binaryimage arch="PowerPC:BE:64:default:elfv2">
<!--
clang -O1, target powerpc64-linux-gnu, -mabi=elfv2 (big-endian ELFv2,
e.g. musl). The ninth integer argument's doubleword is at SP+96, after the
32-byte ELFv2 frame header; big-endian, the 32-bit value is its low word:

unsigned f9(unsigned a, ..., unsigned h, unsigned i) { return a + i; }
unsigned caller(unsigned n) { return f9(n,2,3,4,5,6,7,8,n+9); }

f9: lwz r4,100(r1) caller: addi r4,r3,9
add r3,r4,r3 clrldi r11,r4,32
clrldi r3,r3,32 std r11,96(r1)
blr bl f9

(f9 and caller are separate translation units, so every argument is set.)

The loader picks the `elfv2` compiler spec for a big-endian image whose
e_flags declare ABI version 2; the default big-endian spec is ELFv1's,
with stack parameters at SP+112.
-->
<bytechunk space="ram" offset="0x10000000" readonly="true">
808100647c641a14786300204e800020000000000000000000000000000000003c4c0000384200007c0802a6f821ff91f80100803883000938a00003788b002038800002f961006038c0000438e000053900000639200007394000084bffffa56000000038210070e80100107c0803a64e800020000000000000000000000000
</bytechunk>
<symbol space="ram" offset="0x10000000" name="f9"/>
<symbol space="ram" offset="0x10000020" name="caller"/>
</binaryimage>
<script>
<com>map prototype f9 uint4 f9(uint4 a,uint4 b,uint4 c,uint4 d,uint4 e,uint4 f,uint4 g,uint4 h,uint4 i);</com>
<com>map prototype caller uint4 caller(uint4 n);</com>
<com>lo fu f9</com>
<com>decompile</com>
<com>print C</com>
<com>lo fu caller</com>
<com>decompile</com>
<com>print C</com>
<com>quit</com>
</script>
<stringmatch name="ppc64be-elfv2-stack-args #1: the callee reads its ninth argument" min="1" max="1">return i \+ a;</stringmatch>
<stringmatch name="ppc64be-elfv2-stack-args #2: the caller passes n + 9 as the ninth" min="1" max="1">f9\(n,2,3,4,5,6,7,8,n \+ 9\)</stringmatch>
</decompilertest>
Loading
Loading