Open
Conversation
This already failed to evaluate due to pre-commit's dependency on dotnet-sdk, which is unsupported on i686-linux. This makes `nix flake check --all-systems` succeed again.
edolstra
force-pushed
the
drop-i686-linux
branch
from
e175879 to
92adc41
Compare
Mic92
reviewed
Nov 11, 2025
| constituents = [ | ||
| self.hydraJobs.tarball | ||
| self.hydraJobs.build.x86_64-linux | ||
| self.hydraJobs.build.i686-linux |
Member
There was a problem hiding this comment.
should we not rather exclude pre-commit for 32-bit? I think patchelf in nixpkgs ist still needed for 32-bit libs.
Member
There was a problem hiding this comment.
pkgsi686Linux still has quiet a few references.
Member
Author
There was a problem hiding this comment.
That's what I initially tried, but flake-parts seems to pull in pre-commit as well in the dev shell. We could just remove devShells.i686-linux.default...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This already failed to evaluate due to pre-commit's dependency on dotnet-sdk, which is unsupported on i686-linux.
It also adds
nix flake check --all-systems --no-buildto CI to catch regressions like this.