Skip to content

netgen: remove unused patch#449532

Merged
NickCao merged 1 commit intoNixOS:masterfrom
qbisi:netgen
Oct 10, 2025
Merged

netgen: remove unused patch#449532
NickCao merged 1 commit intoNixOS:masterfrom
qbisi:netgen

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 7, 2025

upstream does not respond to pull request NGSolve/netgen#197 for months
hence we vendor the patch and backport it to 25.05

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qbisi qbisi requested a review from NickCao October 7, 2025 14:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Oct 7, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449532
Commit: 654cf8a81159d550ab5cd15d325c62a0c0d8e31f (subsequent changes)
Merge: fde9cdd57d4c5952a99bd9e39ee86b6f5644a9fa

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18323142167


x86_64-linux

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

aarch64-linux

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

@NickCao
Copy link
Member

NickCao commented Oct 8, 2025

Why do we have to vendor the patch? We can just leave the pr open indefinitely.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

Why do we have to vendor the patch? We can just leave the pr open indefinitely.

I will rebase the pr on master, it no longer apply to v6.2.2506.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 10, 2025

The patch https://github.com/NGSolve/netgen/pull/197/commits/1d93dfba00f224787cfc2cde1af2ab5d7f5b87f7.patch
does not affect compiling netgen itself but rather downstream ngsolve (ngsolve not in nixpkgs yet).
I would consider this url an unstable link, hence remove this patch and backport to 25.05.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449532
Commit: 597c2c6fa5646d18b4ce4f7e0ffa7a6f75141e82 (subsequent changes)
Merge: 301a6974254a2c8f6eaee8a072633894182bda4a

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18416725905


x86_64-linux

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

aarch64-linux

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • netgen (python313Packages.netgen-mesher)
  • python312Packages.netgen-mesher

@qbisi qbisi changed the title netgen: vendor the patch netgen: remove unused patch Oct 10, 2025
@NickCao NickCao added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit c759fc2 Oct 10, 2025
28 of 32 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 10, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants