web: navigate from unresolved to resolved CA build steps - #1682
Merged
Conversation
amaanq
marked this pull request as draft
April 24, 2026 16:09
Member
|
Ericson2314
force-pushed
the
ca-resolve-ui
branch
from
July 18, 2026 17:16
67e07d5 to
cc08266
Compare
Ericson2314
force-pushed
the
ca-resolve-ui
branch
from
July 29, 2026 19:53
cc08266 to
3b1c0ad
Compare
Ericson2314
marked this pull request as ready for review
August 5, 2026 05:31
Ericson2314
force-pushed
the
ca-resolve-ui
branch
from
August 5, 2026 06:12
3b1c0ad to
2b566f0
Compare
Build steps are conceptually a sum type: a real build step, or a Resolved (status=13) step that is a pure redirection to another derivation and never builds anything itself. The UI now reflects that: step pages for Resolved steps show a distinct Resolution layout with the original drv, the resolved basename, and a link to the terminal step (or a pending state when it has not been scheduled yet), instead of the Build/Substitution info table. Resolution is one-shot: a resolved derivation is basic (all inputs realized), so it can never itself be resolved again. There are therefore no resolution chains to follow -- finding the terminal step is a single lookup. Corrupt resolveddrvpath values (a slash, a self-reference) need no special-casing: the lookup simply matches nothing and the step renders as pending. Since a Resolved step never builds, it has no log: its log endpoint returns 404 and the build page offers no log links for such steps. The actual log lives at the terminal step, whose pretty log page carries a banner linking back to the resolution origin(s). Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems> Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Ericson2314
force-pushed
the
ca-resolve-ui
branch
from
August 5, 2026 06:48
2b566f0 to
c8a2df0
Compare
Ericson2314
enabled auto-merge
August 5, 2026 06:50
Ericson2314
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This depends on #1629
Resolved CA steps do not own the log users are trying to inspect, so
leaving them as terminal pages makes the build view look stuck or failed
in the wrong place. The log page now follows the recorded resolution chain
to the step that actually performed the work, while preserving a pending
page for unresolved, running, or malformed chains.
The redirect banner is reconstructed from BuildSteps instead of session
flash so copied log URLs and refreshes keep the same context. The JSON
summary exposes the same durable resolution data for API clients that
need to follow CA build steps without scraping HTML.